Skip to content

Conversation

sdesmalen-arm
Copy link
Collaborator

This also adds the .variant_pcs directive to some functions from which it was previously missing.

This also adds the .variant_pcs directive to some functions from
which it was previously missing.
Copy link
Collaborator

@paulwalker-arm paulwalker-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If .variant_pcs is optional, why do we need it at all?

This is mostly needed because the .variant_pcs directive is required to
build the SME ABI routines, but takes it one step further by requiring
SME assembler support from the compiler. This removes the need for the
macros that use .inst <encoding> otherwise.
@sdesmalen-arm
Copy link
Collaborator Author

If .variant_pcs is optional, why do we need it at all?

AIUI .variant_pcs is not optional. I've removed the support to build these routines when SME ASM support is not available, which also gets rid of some of the macros and cleans up the code a bit further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants