[clang] Emit bad shift warnings #70307

budimirarandjelovichtec · 2023-10-26T08:49:12Z

Diagnose bad shifts and emit warnings

clang/lib/Sema/SemaExpr.cpp

AaronBallman

The patch summary doesn't really explain why the changes are needed. Can you explain what problem you're solving (perhaps link to an issue if this is fixing one that was reported by someone)?

clang/lib/AST/ExprConstant.cpp

clang/test/C/drs/dr0xx.c

clang/test/Sema/shift-count-negative.c

clang/test/Sema/shift-negative-value.c

budimirarandjelovichtec · 2024-01-23T14:21:34Z

The patch summary doesn't really explain why the changes are needed. Can you explain what problem you're solving (perhaps link to an issue if this is fixing one that was reported by someone)?

Main goal of this patch is to enable diagnosing and emitting warnings related to shift operator that are already found by GCC.

Original proposal fix and comments were posted on Pharbricator (link). This patch continues that patch.
Original issue was posted here.

budimirarandjelovichtec · 2024-03-12T11:51:50Z

Ping @AaronBallman

tbaederr · 2024-03-12T11:54:31Z

There are two questions above about removing a diagnostic that you haven't answered yet

clang/lib/AST/ExprConstant.cpp

clang/lib/Sema/SemaExpr.cpp

clang/test/C/drs/dr0xx.c

clang/test/C/drs/dr2xx.c

llvm-ci · 2024-07-11T12:39:15Z

LLVM Buildbot has detected a new failure on builder clang-hip-vega20 running on hip-vega20-0 while building clang at step 3 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/1622

Here is the relevant piece of the build log for the reference:

Step 3 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/hip-build.sh --jobs=' (failure)
...
[36/38] : && /buildbot/hip-vega20-0/clang-hip-vega20/llvm/bin/clang++ -O3 -DNDEBUG  External/HIP/CMakeFiles/InOneWeekend-hip-6.0.2.dir/workload/ray-tracing/InOneWeekend/main.cc.o -o External/HIP/InOneWeekend-hip-6.0.2  --rocm-path=/buildbot/Externals/hip/rocm-6.0.2 --hip-link -rtlib=compiler-rt -unwindlib=libgcc -frtlib-add-rpath && cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP && /usr/local/bin/cmake -E create_symlink /buildbot/llvm-test-suite/External/HIP/InOneWeekend.reference_output /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/InOneWeekend.reference_output-hip-6.0.2
[37/38] /buildbot/hip-vega20-0/clang-hip-vega20/llvm/bin/clang++ -DNDEBUG  -O3 -DNDEBUG   -w -Werror=date-time --rocm-path=/buildbot/Externals/hip/rocm-6.0.2 --offload-arch=gfx908 --offload-arch=gfx90a --offload-arch=gfx1030 --offload-arch=gfx1100 -xhip -mfma -MD -MT External/HIP/CMakeFiles/TheNextWeek-hip-6.0.2.dir/workload/ray-tracing/TheNextWeek/main.cc.o -MF External/HIP/CMakeFiles/TheNextWeek-hip-6.0.2.dir/workload/ray-tracing/TheNextWeek/main.cc.o.d -o External/HIP/CMakeFiles/TheNextWeek-hip-6.0.2.dir/workload/ray-tracing/TheNextWeek/main.cc.o -c /buildbot/llvm-test-suite/External/HIP/workload/ray-tracing/TheNextWeek/main.cc
[38/38] : && /buildbot/hip-vega20-0/clang-hip-vega20/llvm/bin/clang++ -O3 -DNDEBUG  External/HIP/CMakeFiles/TheNextWeek-hip-6.0.2.dir/workload/ray-tracing/TheNextWeek/main.cc.o -o External/HIP/TheNextWeek-hip-6.0.2  --rocm-path=/buildbot/Externals/hip/rocm-6.0.2 --hip-link -rtlib=compiler-rt -unwindlib=libgcc -frtlib-add-rpath && cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP && /usr/local/bin/cmake -E create_symlink /buildbot/llvm-test-suite/External/HIP/TheNextWeek.reference_output /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/TheNextWeek.reference_output-hip-6.0.2
+ build_step 'Testing HIP test-suite'
+ echo '@@@BUILD_STEP Testing HIP test-suite@@@'
@@@BUILD_STEP Testing HIP test-suite@@@
+ ninja -v check-hip-simple
[0/1] cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP && /buildbot/hip-vega20-0/clang-hip-vega20/llvm/bin/llvm-lit -sv empty-hip-6.0.2.test with-fopenmp-hip-6.0.2.test saxpy-hip-6.0.2.test InOneWeekend-hip-6.0.2.test TheNextWeek-hip-6.0.2.test blender.test
-- Testing: 6 tests, 6 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 
FAIL: test-suite :: External/HIP/InOneWeekend-hip-6.0.2.test (4 of 6)
******************** TEST 'test-suite :: External/HIP/InOneWeekend-hip-6.0.2.test' FAILED ********************

/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/timeit-target --timeout 7200 --limit-core 0 --limit-cpu 7200 --limit-file-size 209715200 --limit-rss-size 838860800 --append-exitstatus --redirect-output /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.out --redirect-input /dev/null --summary /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.time /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/InOneWeekend-hip-6.0.2
cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP ; /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/fpcmp-target /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.out InOneWeekend.reference_output-hip-6.0.2

+ cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP
+ /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/fpcmp-target /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.out InOneWeekend.reference_output-hip-6.0.2
/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/fpcmp-target: Comparison failed, textual difference between 'M' and 'i'

********************
/usr/bin/strip: /bin/bash.stripped: Bad file descriptor
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  test-suite :: External/HIP/InOneWeekend-hip-6.0.2.test


Testing Time: 385.34s

Total Discovered Tests: 6
  Passed: 5 (83.33%)
  Failed: 1 (16.67%)
FAILED: External/HIP/CMakeFiles/check-hip-simple-hip-6.0.2 
cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP && /buildbot/hip-vega20-0/clang-hip-vega20/llvm/bin/llvm-lit -sv empty-hip-6.0.2.test with-fopenmp-hip-6.0.2.test saxpy-hip-6.0.2.test InOneWeekend-hip-6.0.2.test TheNextWeek-hip-6.0.2.test blender.test
ninja: build stopped: subcommand failed.
Step 12 (Testing HIP test-suite) failure: Testing HIP test-suite (failure)
@@@BUILD_STEP Testing HIP test-suite@@@
+ ninja -v check-hip-simple
[0/1] cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP && /buildbot/hip-vega20-0/clang-hip-vega20/llvm/bin/llvm-lit -sv empty-hip-6.0.2.test with-fopenmp-hip-6.0.2.test saxpy-hip-6.0.2.test InOneWeekend-hip-6.0.2.test TheNextWeek-hip-6.0.2.test blender.test
-- Testing: 6 tests, 6 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 
FAIL: test-suite :: External/HIP/InOneWeekend-hip-6.0.2.test (4 of 6)
******************** TEST 'test-suite :: External/HIP/InOneWeekend-hip-6.0.2.test' FAILED ********************

/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/timeit-target --timeout 7200 --limit-core 0 --limit-cpu 7200 --limit-file-size 209715200 --limit-rss-size 838860800 --append-exitstatus --redirect-output /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.out --redirect-input /dev/null --summary /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.time /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/InOneWeekend-hip-6.0.2
cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP ; /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/fpcmp-target /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.out InOneWeekend.reference_output-hip-6.0.2

+ cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP
+ /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/fpcmp-target /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP/Output/InOneWeekend-hip-6.0.2.test.out InOneWeekend.reference_output-hip-6.0.2
/buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/tools/fpcmp-target: Comparison failed, textual difference between 'M' and 'i'

********************
/usr/bin/strip: /bin/bash.stripped: Bad file descriptor
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  test-suite :: External/HIP/InOneWeekend-hip-6.0.2.test


Testing Time: 385.34s

Total Discovered Tests: 6
  Passed: 5 (83.33%)
  Failed: 1 (16.67%)
FAILED: External/HIP/CMakeFiles/check-hip-simple-hip-6.0.2 
cd /buildbot/hip-vega20-0/clang-hip-vega20/test-suite-build/External/HIP && /buildbot/hip-vega20-0/clang-hip-vega20/llvm/bin/llvm-lit -sv empty-hip-6.0.2.test with-fopenmp-hip-6.0.2.test saxpy-hip-6.0.2.test InOneWeekend-hip-6.0.2.test TheNextWeek-hip-6.0.2.test blender.test
ninja: build stopped: subcommand failed.
program finished with exit code 1
elapsedTime=543.516237

alanzhao1 · 2024-07-11T21:42:26Z

FYI this is causing breakages in chrome - the android NDK has an enum element set equal to 1UL << 32 and we get a compile failure for --target=i686-linux-android26. See https://crbug.com/352592408,

code in question is here: https://android.googlesource.com/platform/frameworks/native/+/master/libs/nativewindow/include/android/hardware_buffer.h#329

The android NDK code is wrong, but this no longer compiles (even with -Wno-error).

AaronBallman · 2024-07-12T11:02:39Z

The android NDK code is wrong, but this no longer compiles (even with -Wno-error).

Well that's unfortunate! Thank you for letting us know.

@alanzhao1 do you think it's reasonable for the workaround to only apply to code in system headers, or does the NDK get included as regular headers generally? Do you need us to revert the changes while we resolve this?

@budimirarandjelovicsyrmia, can you please add a workaround so that the NDK code can continue to compile?

budimirarandjelovichtec · 2024-07-12T13:38:09Z

@budimirarandjelovicsyrmia, can you please add a workaround so that the NDK code can continue to compile?

I will investigate this.

alanzhao1 · 2024-07-12T18:09:17Z

@alanzhao1 do you think it's reasonable for the workaround to only apply to code in system headers, or does the NDK get included as regular headers generally?

Having it only apply to system headers should be OK - in our case, chrome imports these headers as part of a --sysroot, which IIRC treats warnings the same way as -isystem

Do you need us to revert the changes while we resolve this?

If you can revert while working on a solution, that would be helpful.

@budimirarandjelovicsyrmia, can you please add a workaround so that the NDK code can continue to compile?

I will investigate this.

FYI I noticed that gcc can compile this with -fpermissive

Diagnose bad shifts and emit warnings

stbergmann · 2024-07-15T12:04:00Z

This started to cause

$ cat test.c
#include <string.h>
void f(void) {
    char a[strlen("x")];
    (void) a;
}

$ clang -Wall -fsyntax-only test.c
test.c:3:12: warning: variable length array folded to constant array as an extension [-Wgnu-folding-constant]
    3 |     char a[strlen("x")];
      |            ^~~~~~~~~~~
1 warning generated.

to emit a warning, and I'm not sure that's intentional?

AaronBallman · 2024-07-15T12:51:39Z

This started to cause

$ cat test.c
#include <string.h>
void f(void) {
    char a[strlen("x")];
    (void) a;
}

$ clang -Wall -fsyntax-only test.c
test.c:3:12: warning: variable length array folded to constant array as an extension [-Wgnu-folding-constant]
    3 |     char a[strlen("x")];
      |            ^~~~~~~~~~~
1 warning generated.

to emit a warning, and I'm not sure that's intentional?

That is intentional; strlen is not a valid constant expression in C, and so that is technically a VLA, except we have an extension to fold it back into a constant.

stbergmann · 2024-07-15T13:02:41Z

That is intentional; strlen is not a valid constant expression in C, and so that is technically a VLA, except we have an extension to fold it back into a constant.

Thanks for confirming. From the commit message and the changes to clang/docs/ReleaseNotes.rst it just didn't look like this newly emitted warning was intended by the commit. But now I notice the changes to clang/test/Sema/builtins.c that do acknowledge this newly emitted warning.

> desktop/unx/source/start.c:788:23: error: variable length array folded to constant array as an extension [-Werror,-Wgnu-folding-constant] > 788 | char resp[strlen("InternalIPC::SendArguments") + 1]; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ since <llvm/llvm-project@e4163c0> "[clang] Emit bad shift warnings (#70307)" (and see the comments starting at <llvm/llvm-project#70307 (comment)> "[clang] Emit bad shift warnings" for how this new warning is indeed intentional) Change-Id: Ie439a0f5f6f3b256fa82ec3a05fdc5fb3b840715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170510 Reviewed-by: Stephan Bergmann <[email protected]> Tested-by: Jenkins

alexfh · 2024-07-18T08:50:57Z

Just to confirm: is this the intentional outcome of this patch?
https://gcc.godbolt.org/z/Kf9YK1qM3

enum {
    a = 1<<12,
    b = (-1)<<13
};

<source>:3:9: error: expression is not an integral constant expression
    3 |     b = (-1)<<13
      |         ^~~~~~~~
<source>:3:13: note: left shift of negative value -1
    3 |     b = (-1)<<13
      |             ^

Though technically, it's UB before C++20, the diagnostic - "expression is not an integral constant expression" - doesn't sound helpful (how is it not constant or not integral?). And what's worse, is that it's an error rather than a warning that can be disabled.

AaronBallman · 2024-07-18T11:48:07Z

Just to confirm: is this the intentional outcome of this patch?

Before C++20, left shift of -1 does not produce a mathematical result that's within the range of representable values for the result type, so it's undefined behavior, and therefore not a core constant expression, and therefore invalid as the initializer for an enumeration constant. So I believe the behavior is expected and correct; you can see the UB diagnostic in other contexts: https://gcc.godbolt.org/z/bqj6xhzzr and GCC agrees with Clang in the enumeration case: https://gcc.godbolt.org/z/qjKzeaYTz

the diagnostic - "expression is not an integral constant expression" - doesn't sound helpful (how is it not constant or not integral?). And what's worse, is that it's an error rather than a warning that can be disabled.

It has integral constants but it's not an integral constant expression as far as the language is concerned. The note tells you why it's not a valid integral constant expression. As for warning vs error; the standard makes the code ill-formed and we treat that as an error generally speaking.

If you can't enable C++20 mode, you can still get the same value in C++17 and earlier with well-formed code: https://gcc.godbolt.org/z/3ra83joqs

alexfh · 2024-07-18T12:55:49Z

I see. Thanks for the explanation and for the suggestion on how to fix that. Actually, the only instance I've seen, had already been fixed upstream (https://hg.openjdk.org/jdk/jdk/rev/71495d579a65), so the impact of this compiler behavior change is quite low in my part of the universe.

alexfh · 2024-07-18T13:22:36Z

Now there's a different and more subtle side-effect of this patch: https://gcc.godbolt.org/z/YP3EfGern

The invalid expression 1 << 59 leads to the compiler silently ignoring the in-class initializer of the static data member.

AaronBallman · 2024-07-18T13:31:22Z

Now there's a different and more subtle side-effect of this patch: https://gcc.godbolt.org/z/YP3EfGern

The invalid expression 1 << 59 leads to the compiler silently ignoring the in-class initializer of the static data member.

Huh, I don't think that's an intentional change in this patch, good catch! Adding -pedantic to the command line yields warning: in-class initializer for static data member is not a constant expression; folding it to a constant is a GNU extension so I think we're missing that constant folding behavior at codegen time. CC @efriedma-quic @rjmccall for opinions

efriedma-quic · 2024-07-18T19:14:49Z

I think the issue is the usage of "Info.EvalStatus.Diag" to determine whether we consider the expression an ICE; that's going to lead to unpredictable results, and it's not how we handle things anywhere else. Not sure what the goal of that change is.

Separately, Sema::AddInitializerToDecl should probably print diagnostics when it checks for an ICE, instead of just emitting the generic diag::err_in_class_initializer_non_constant/diag::ext_in_class_initializer_non_constant. Any maybe we should consider enabling ext_in_class_initializer_non_constant by default.

alanzhao1 · 2024-07-18T19:40:51Z

@alanzhao1 do you think it's reasonable for the workaround to only apply to code in system headers, or does the NDK get included as regular headers generally?

Having it only apply to system headers should be OK - in our case, chrome imports these headers as part of a --sysroot, which IIRC treats warnings the same way as -isystem

Do you need us to revert the changes while we resolve this?

If you can revert while working on a solution, that would be helpful.

We (Chrome) no longer need a revert - we patched the NDK locally.

efriedma-quic · 2024-07-18T22:03:05Z

Posted #99579.

AaronBallman · 2024-07-19T12:50:32Z

@alanzhao1 do you think it's reasonable for the workaround to only apply to code in system headers, or does the NDK get included as regular headers generally?

Having it only apply to system headers should be OK - in our case, chrome imports these headers as part of a --sysroot, which IIRC treats warnings the same way as -isystem

Do you need us to revert the changes while we resolve this?

If you can revert while working on a solution, that would be helpful.

We (Chrome) no longer need a revert - we patched the NDK locally.

Thank you for letting us know!

This patch removes trailing whitespace from `SemaExpr.cpp` added by #70307

glandium · 2024-08-07T07:48:15Z

We (Chrome) no longer need a revert - we patched the NDK locally.

Patching the NDK is not a solution that is nice everywhere, though. And the new warning is an error that can't be disabled.

AaronBallman · 2024-08-07T13:37:12Z

We (Chrome) no longer need a revert - we patched the NDK locally.

Patching the NDK is not a solution that is nice everywhere, though. And the new warning is an error that can't be disabled.

FWIW, we addressed this issue and backported the fix in #100452 -- are you seeing issues with the latest release candidate?

efriedma-quic · 2024-08-07T19:48:40Z

#100452 only fixed the "ignoring the in-class initializer of the static data member" issue. I don't think we did anything to allow downgrading overflow errors to warnings.

glandium · 2024-08-07T20:53:49Z

We (Chrome) no longer need a revert - we patched the NDK locally.

Patching the NDK is not a solution that is nice everywhere, though. And the new warning is an error that can't be disabled.

FWIW, we addressed this issue and backported the fix in #100452 -- are you seeing issues with the latest release candidate?

I don't know about the latest release candidate, but trunk still has the problem.

efriedma-quic · 2024-08-07T22:03:44Z

#102390 "fixes" the Android NDK issue.

llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Oct 26, 2023

AaronBallman requested review from AaronBallman, shafik and tbaederr October 26, 2023 12:43

shafik reviewed Oct 28, 2023

View reviewed changes

clang/lib/Sema/SemaExpr.cpp Outdated Show resolved Hide resolved

budimirarandjelovichtec force-pushed the left-shift-count branch from 894d650 to c9b85c8 Compare November 17, 2023 14:00

AaronBallman reviewed Jan 11, 2024

View reviewed changes

budimirarandjelovichtec force-pushed the left-shift-count branch from c9b85c8 to c89be5f Compare January 23, 2024 14:44

budimirarandjelovichtec force-pushed the left-shift-count branch from c89be5f to c9ef2f2 Compare March 20, 2024 15:39

AaronBallman requested changes Mar 25, 2024

View reviewed changes

clang/lib/AST/ExprConstant.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaExpr.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaExpr.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaExpr.cpp Outdated Show resolved Hide resolved

budimirarandjelovichtec force-pushed the left-shift-count branch from c9ef2f2 to 17fb77d Compare March 26, 2024 10:42

AaronBallman reviewed Mar 26, 2024

View reviewed changes

clang/lib/Sema/SemaExpr.cpp Outdated Show resolved Hide resolved

budimirarandjelovichtec force-pushed the left-shift-count branch 3 times, most recently from 0ed3473 to 69c6fc0 Compare June 18, 2024 09:56

AaronBallman reviewed Jun 18, 2024

View reviewed changes

clang/test/C/drs/dr0xx.c Outdated Show resolved Hide resolved

clang/test/C/drs/dr2xx.c Outdated Show resolved Hide resolved

budimirarandjelovichtec force-pushed the left-shift-count branch 8 times, most recently from 9e4309a to a66ca21 Compare June 27, 2024 11:37

budimirarandjelovichtec closed this Jun 27, 2024

budimirarandjelovichtec force-pushed the left-shift-count branch from a66ca21 to a46a2c2 Compare June 27, 2024 12:13

djtodoro merged commit e4163c0 into llvm:main Jul 11, 2024
6 checks passed

aaryanshukla pushed a commit to aaryanshukla/llvm-project that referenced this pull request Jul 14, 2024

[clang] Emit bad shift warnings (llvm#70307)

cb3eb49

Diagnose bad shifts and emit warnings

sdkrystian mentioned this pull request Aug 5, 2024

[Clang][NFC] Remove trailing whitespace from SemaExpr.cpp #102001

Merged

sdkrystian added a commit that referenced this pull request Aug 5, 2024

[Clang][NFC] Remove trailing whitespace from SemaExpr.cpp (#102001)

0b2d50c

This patch removes trailing whitespace from `SemaExpr.cpp` added by #70307

efriedma-quic mentioned this pull request Aug 7, 2024

Add flag to suppress overflow errors in C++ constant expressions. #102390

Closed

[clang] Emit bad shift warnings #70307

[clang] Emit bad shift warnings #70307

Uh oh!

Conversation

budimirarandjelovichtec commented Oct 26, 2023

Uh oh!

Uh oh!

AaronBallman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

budimirarandjelovichtec commented Jan 23, 2024

Uh oh!

budimirarandjelovichtec commented Mar 12, 2024

Uh oh!

tbaederr commented Mar 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

llvm-ci commented Jul 11, 2024

Uh oh!

alanzhao1 commented Jul 11, 2024

Uh oh!

AaronBallman commented Jul 12, 2024

Uh oh!

budimirarandjelovichtec commented Jul 12, 2024

Uh oh!

alanzhao1 commented Jul 12, 2024

Uh oh!

stbergmann commented Jul 15, 2024

Uh oh!

AaronBallman commented Jul 15, 2024

Uh oh!

stbergmann commented Jul 15, 2024

Uh oh!

alexfh commented Jul 18, 2024

Uh oh!

AaronBallman commented Jul 18, 2024

Uh oh!

alexfh commented Jul 18, 2024

Uh oh!

alexfh commented Jul 18, 2024

Uh oh!

AaronBallman commented Jul 18, 2024

Uh oh!

efriedma-quic commented Jul 18, 2024

Uh oh!

alanzhao1 commented Jul 18, 2024

Uh oh!

efriedma-quic commented Jul 18, 2024

Uh oh!

AaronBallman commented Jul 19, 2024

Uh oh!

glandium commented Aug 7, 2024

Uh oh!

AaronBallman commented Aug 7, 2024

Uh oh!

efriedma-quic commented Aug 7, 2024

Uh oh!

glandium commented Aug 7, 2024

Uh oh!

efriedma-quic commented Aug 7, 2024

Uh oh!

Uh oh!