Skip to content

[mlir][ArmSME] Add optional mask operand to tile_store #70657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2023
Merged

[mlir][ArmSME] Add optional mask operand to tile_store #70657

merged 3 commits into from
Nov 1, 2023

Conversation

c-rhodes
Copy link
Collaborator

No description provided.

c-rhodes
c-rhodes commented Oct 30, 2023
View reviewed changes
mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td Outdated
Comment on lines +63 to +67
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MacDue I've based on the constraint you're adding in #69604 but parameterized it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to rebase and de-duplicate this now :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@MacDue MacDue mentioned this pull request Oct 31, 2023
Merged
@c-rhodes c-rhodes force-pushed the mlir-arm-sme-tile-store-mask branch from 1cfe5d2 to f1cf692 Compare October 31, 2023 14:32
MacDue
MacDue approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@MacDue MacDue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of little comments:

@c-rhodes c-rhodes merged commit 1908f47 into llvm:main Nov 1, 2023
@c-rhodes c-rhodes deleted the mlir-arm-sme-tile-store-mask branch November 1, 2023 07:15
@c-rhodes c-rhodes mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MacDue MacDue MacDue approved these changes

@banach-space banach-space Awaiting requested review from banach-space banach-space is a code owner

@dcaballe dcaballe Awaiting requested review from dcaballe dcaballe is a code owner

Assignees

No one assigned

Labels

mlir:sme mlir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-rhodes @MacDue @llvmbot