CodeGen: Port ExpandLargeDivRem to new pass manager #71022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
force-pushed
the
newpm/expand-large-div-rem
branch
from
d2dd5e1 to
312fb7d
Compare
arsenm
commented
Nov 2, 2023
| @@ -445,6 +445,7 @@ FUNCTION_PASS("transform-warning", WarnMissedTransformationsPass()) | |||
| FUNCTION_PASS("tsan", ThreadSanitizerPass()) | |||
| FUNCTION_PASS("memprof", MemProfilerPass()) | |||
| FUNCTION_PASS("declare-to-assign", llvm::AssignmentTrackingPass()) | |||
| FUNCTION_PASS("expand-large-div-rem", ExpandLargeDivRemPass(TM)); | |||
There was a problem hiding this comment.
This seems to already exist without the constructor argument in MachinePassRegistry.def, not sure what's going on there
There was a problem hiding this comment.
what do you mean?
$ ./build/rel/bin/opt -p expand-large-div-rem -S /dev/null
./build/rel/bin/opt: unknown pass name 'expand-large-div-rem'
There was a problem hiding this comment.
I mean this exists:
aeubanks
approved these changes
Nov 2, 2023
| @@ -445,6 +445,7 @@ FUNCTION_PASS("transform-warning", WarnMissedTransformationsPass()) | |||
| FUNCTION_PASS("tsan", ThreadSanitizerPass()) | |||
| FUNCTION_PASS("memprof", MemProfilerPass()) | |||
| FUNCTION_PASS("declare-to-assign", llvm::AssignmentTrackingPass()) | |||
| FUNCTION_PASS("expand-large-div-rem", ExpandLargeDivRemPass(TM)); | |||
There was a problem hiding this comment.
what do you mean?
$ ./build/rel/bin/opt -p expand-large-div-rem -S /dev/null
./build/rel/bin/opt: unknown pass name 'expand-large-div-rem'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.