[OpenMP][flang] Adding more tests for commonblock with target map #71146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shraiysh
requested review from
kiranchandramohan,
raghavendhra,
agozillon,
DominikAdamski and
kiranktp
|
@agozillon @TIFitis Are you OK with these tests? |
TIFitis
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Test commonblock_simple_to is already testing the for map-type isn't it?
There was a problem hiding this comment.
Yes, that is correct. Removed this redundant test. Thanks!
There was a problem hiding this comment.
Can you remove the explicit mapping from this test? I guess we want to check implicit mapping here.
There was a problem hiding this comment.
This test checks if a variable with implicit type gets mapped accurately. This test does not check the implicit mapping. I will rename it to commonblock_simple_with_implicit_type_var.
shraiysh
force-pushed
the
more_tests_for_commonblock
branch
from
714c7e3 to
44482f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses the concern about multiple devices and also adds more tests for
map(to:),map(from:)and named common blocks.