Skip to content

Conversation

shafik
Copy link
Collaborator

@shafik shafik commented Nov 7, 2023

@shafik shafik merged commit ef618b5 into main Nov 7, 2023
@shafik shafik deleted the revert-71435-fix_fixme_in_redeclarable branch November 7, 2023 02:22
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Nov 7, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 7, 2023

@llvm/pr-subscribers-clang

Author: Shafik Yaghmour (shafik)

Changes

Reverts llvm/llvm-project#71435

This is failing on some build bots e.g.: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/62315/consoleFull#-3939952849ba4694-19c4-4d7e-bec5-911270d8a58c


Full diff: https://github.com/llvm/llvm-project/pull/71478.diff

1 Files Affected:

  • (modified) clang/include/clang/AST/Redeclarable.h (+3-1)
diff --git a/clang/include/clang/AST/Redeclarable.h b/clang/include/clang/AST/Redeclarable.h
index be022bf5322ad61..091bb886f2d4962 100644
--- a/clang/include/clang/AST/Redeclarable.h
+++ b/clang/include/clang/AST/Redeclarable.h
@@ -114,7 +114,9 @@ class Redeclarable {
 
     bool isFirst() const {
       return Link.is<KnownLatest>() ||
-             Link.get<NotKnownLatest>().is<UninitializedLatest>();
+             // FIXME: 'template' is required on the next line due to an
+             // apparent clang bug.
+             Link.get<NotKnownLatest>().template is<UninitializedLatest>();
     }
 
     decl_type *getPrevious(const decl_type *D) const {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants