[libc++] Update Clang version check in __config #71849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only support Clang >= 16, but we seem to have forgotten to update the version theck in __config to reflect that.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesWe only support Clang >= 16, but we seem to have forgotten to update the version theck in __config to reflect that. Full diff: https://github.com/llvm/llvm-project/pull/71849.diff 1 Files Affected:
diff --git a/libcxx/include/__config b/libcxx/include/__config
index 39148ae2b184196..4412deb930cb45b 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -33,8 +33,8 @@
// Warn if a compiler version is used that is not supported anymore
// LLVM RELEASE Update the minimum compiler versions
# if defined(_LIBCPP_CLANG_VER)
-# if _LIBCPP_CLANG_VER < 1500
-# warning "Libc++ only supports Clang 15 and later"
+# if _LIBCPP_CLANG_VER < 1600
+# warning "Libc++ only supports Clang 16 and later"
# endif
# elif defined(_LIBCPP_APPLE_CLANG_VER)
# if _LIBCPP_APPLE_CLANG_VER < 1500
|
philnik777
approved these changes
Nov 9, 2023
AdvenamTacet
approved these changes
Nov 10, 2023
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
We only support Clang >= 16, but we seem to have forgotten to update the version check in __config to reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only support Clang >= 16, but we seem to have forgotten to update the version theck in __config to reflect that.