Skip to content

[readtapi] Add Extract & Remove architecture functionality #72657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

cyndyishida
Copy link
Member

@cyndyishida cyndyishida commented Nov 17, 2023

NOTE: This is a part of a stack. Please review #72656 first.

This adds functionality to tbd files similar to what lipo -extract
and lipo -remove does for binaries.

@cyndyishida cyndyishida force-pushed the eng/PR-tapiArchivep2 branch 2 times, most recently from 94ca152 to 2538349 Compare November 17, 2023 23:32
This adds functionality to tbd files similiar to what `lipo -extract`
and `lipo -remove` does for binaries.
Copy link
Collaborator

@ributzka ributzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please add a comment at the beginning of each test and summarize what is being tested?

@cyndyishida cyndyishida merged commit e1f69b8 into llvm:main Nov 27, 2023
@cyndyishida
Copy link
Member Author

LGTM. Could you please add a comment at the beginning of each test and summarize what is being tested?

Addressed in #73576

cyndyishida added a commit to cyndyishida/llvm-project that referenced this pull request Jan 4, 2024
This adds functionality to tbd files similar to what `lipo -extract`
and `lipo -remove` does for binaries.

(cherry picked from commit e1f69b8)
cyndyishida added a commit to swiftlang/llvm-project that referenced this pull request Jan 5, 2024
This adds functionality to tbd files similar to what `lipo -extract`
and `lipo -remove` does for binaries.

(cherry picked from commit e1f69b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants