Skip to content

[CMake] Always define runtimes-test-depends #73629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[CMake] Always define runtimes-test-depends #73629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion runtimes/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,14 @@ foreach(entry ${runtimes})
add_subdirectory(${entry} ${projName})
endforeach()

# Define runtimes-test-depends so the parent build can use it unconditionally.
add_custom_target(runtimes-test-depends)

if(LLVM_INCLUDE_TESTS)
# LLVM_RUNTIMES_LIT_DEPENDS is populated when lit tests are added between
# umbrella_list_testsuite begin and end. The bootstrap runtimes builds
# currently assumes this target exists.
get_property(LLVM_RUNTIMES_LIT_DEPENDS GLOBAL PROPERTY LLVM_RUNTIMES_LIT_DEPENDS)
add_custom_target(runtimes-test-depends)
if(LLVM_RUNTIMES_LIT_DEPENDS)
# add_dependencies complains if called with no dependencies
add_dependencies(runtimes-test-depends ${LLVM_RUNTIMES_LIT_DEPENDS})
Expand Down