[NFC] Adding missing flang tests for LTO bugfix

[paschalis-mpeis]

Pull request #78749 introduced a fix for passing vector library flags from clang frontend to opt when LTO is used.

The fix also covered flang, as it's handled in CommonArgs.cpp, but no testing was added for flang.

[llvmbot]

@llvm/pr-subscribers-flang-driver

Author: Paschalis Mpeis (paschalis-mpeis)

Changes

Pull request #78749 introduced a fix for passing vector library flags from clang frontend to opt when LTO is used.

The fix also covered flang, as it's handled in CommonArgs.cpp, but no testing was added for flang.

---

Full diff: https://github.com/llvm/llvm-project/pull/80417.diff

1 Files Affected:

• (modified) flang/test/Driver/fveclib.f90 (+17)

diff --git a/flang/test/Driver/fveclib.f90 b/flang/test/Driver/fveclib.f90
index 14c59b0616f82..76071c2255a47 100644
--- a/flang/test/Driver/fveclib.f90
+++ b/flang/test/Driver/fveclib.f90
@@ -30,3 +30,20 @@
 
 ! TODO: if we add support for -nostdlib or -nodefaultlibs we need to test that
 ! these prevent "-framework Accelerate" being added on Darwin
+
+! Verify that the correct vector library is passed to LTO flags.
+
+! RUN: %flang -### --target=x86_64-unknown-linux-gnu -fveclib=LIBMVEC -flto %s 2>&1 | FileCheck -check-prefix CHECK-LTO-LIBMVEC %s
+! CHECK-LTO-LIBMVEC: "-plugin-opt=-vector-library=LIBMVEC-X86"
+
+! RUN: %flang -### --target=powerpc64-unknown-linux-gnu -fveclib=MASSV -flto %s 2>&1 | FileCheck -check-prefix CHECK-LTO-MASSV %s
+! CHECK-LTO-MASSV: "-plugin-opt=-vector-library=MASSV"
+
+! RUN: %flang -### --target=x86_64-unknown-linux-gnu -fveclib=SVML -flto %s 2>&1 | FileCheck -check-prefix CHECK-LTO-SVML %s
+! CHECK-LTO-SVML: "-plugin-opt=-vector-library=SVML"
+
+! RUN: %flang -### --target=aarch64-linux-gnu -fveclib=SLEEF -flto %s 2>&1 | FileCheck -check-prefix CHECK-LTO-SLEEF %s
+! CHECK-LTO-SLEEF: "-plugin-opt=-vector-library=sleefgnuabi"
+
+! RUN: %flang -### --target=aarch64-linux-gnu -fveclib=ArmPL -flto %s 2>&1 | FileCheck -check-prefix CHECK-LTO-ARMPL %s
+! CHECK-LTO-ARMPL: "-plugin-opt=-vector-library=ArmPL"

[tblah]

LGTM, thanks for adding the tests

[paschalis-mpeis]

Thanks Tom.

For the rest of the reviewers, the tests added are mirroring these clang tests

• from [LTO] Fix Veclib flags correctly pass to LTO flags #78749

[banach-space]

Thanks for this patch!

The fix also covered flang, as it's handled in CommonArgs.cpp, but no testing was added for flang.

From your summary, this particular logic in CommonArgs.cpp is already tested in Clang. IMHO, we should avoid duplicating tests like this. Sometimes that's tricky to avoid, especially when enabling new options in Flang. However, in this case, it seems quite apparent that testing in Flang is not going to increase the test coverage. I might be missing something though.

[paschalis-mpeis]

@banach-space thanks for your comment.

As this is not aligned with on-going and future direction of flags in clang/flang fron-ends, I've decided to not land this patch.