PR for llvm/llvm-project#80348 #80585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying a cherry-picked patch to fix code formatting issues can be risky, so we don't typically do this. Therefore, it's not necessary to run this job on the release branches. (cherry picked from commit 2193c95)
|
@tru What do you think about merging this PR to the release branch? |
|
@llvm/pr-subscribers-github-workflow Author: None (llvmbot) Changesresolves llvm/llvm-project#80348 Full diff: https://github.com/llvm/llvm-project/pull/80585.diff 1 Files Affected:
diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index 5223089ee8a93..c8fd541fd34db 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -1,5 +1,8 @@
name: "Check code formatting"
on: pull_request_target
+ branches:
+ - main
+
permissions:
pull-requests: write
|
There was a problem hiding this comment.
This is incorrectly formatted (sorry for not catching that in my initial review).
It should be the following:
on:
pull_request_target:
branches:
- mainI pushed a fixup to main 4b34558.
|
/cherry-pick 4b34558. |
|
Failed to cherry-pick: 4b34558. https://github.com/llvm/llvm-project/actions/runs/7789532649 Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request |
|
/pull-request #80776 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #80348