[Sanitizers][ABI] Remove too strong assert in asan_abi_shim #81696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
compiler-rt
compiler-rt:asan
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Mariusz Borsa (wrotki) ChangesRecently we enabled building the shim for arm64_32 arch. On this arch, sizeof(uptr) == sizeof(unsigned long) == 4 - so this assert will fail in runtime. Need to just remove this assert rdar://122927166 Full diff: https://github.com/llvm/llvm-project/pull/81696.diff 1 Files Affected:
diff --git a/compiler-rt/lib/asan_abi/asan_abi_shim.cpp b/compiler-rt/lib/asan_abi/asan_abi_shim.cpp
index 35c45dff96f6d2..523b322618b850 100644
--- a/compiler-rt/lib/asan_abi/asan_abi_shim.cpp
+++ b/compiler-rt/lib/asan_abi/asan_abi_shim.cpp
@@ -54,7 +54,6 @@ void *__asan_memmove(void *dest, const void *src, uptr n) {
// Functions concerning RTL startup and initialization
void __asan_init(void) {
- static_assert(sizeof(uptr) == 8);
static_assert(sizeof(u64) == 8);
static_assert(sizeof(u32) == 4);
|
|
Suggestion: relax the assertion to |
|
LGTM |
thurstond
approved these changes
Feb 14, 2024
usama54321
approved these changes
Feb 14, 2024
rsundahl
approved these changes
Feb 14, 2024
Recently we enabled building the shim for arm64_32 arch. On this arch, sizeof(uptr) == sizeof(unsigned long) == 4 - so this assert will fail in runtime. Relaxing the assert per suggestion on the PR rdar://122927166
wrotki
force-pushed
the
remove_invalid_assert
branch
from
7bc8143 to
5ec31f0
Compare
Sure, will do that, thanks!
Did that, thanks for the suggestion! |
wrotki
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 15, 2024
Recently we enabled building the shim for arm64_32 arch. On this arch, sizeof(uptr) == sizeof(unsigned long) == 4 - so this assert will fail in runtime. Need to just remove this assert rdar://122927166 Co-authored-by: Mariusz Borsa <[email protected]> (cherry picked from commit 3f738a4)
wrotki
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Feb 15, 2024
[Sanitizers][ABI] Remove too strong assert in asan_abi_shim (llvm#81696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we enabled building the shim for arm64_32 arch. On this arch, sizeof(uptr) == sizeof(unsigned long) == 4 - so this assert will fail in runtime.
Need to just remove this assert
rdar://122927166