[compiler-rt][fuzzer] windows build unbreak proposal. #83538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: David CARLIER (devnexen) Changesshuffling the order of its includes. Full diff: https://github.com/llvm/llvm-project/pull/83538.diff 1 Files Affected:
diff --git a/compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp b/compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp
index 13f9a67a2f0fe3..31947dd120bac0 100644
--- a/compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp
+++ b/compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp
@@ -18,12 +18,14 @@
#include <errno.h>
#include <io.h>
#include <iomanip>
-#include <libloaderapi.h>
#include <signal.h>
#include <stdio.h>
-#include <stringapiset.h>
#include <sys/types.h>
+// clang-format off
#include <windows.h>
+#include <libloaderapi.h>
+#include <stringapiset.h>
+// clang-format on
// This must be included after windows.h.
#include <psapi.h>
|
|
cc @glandium. |
vitalybuka
reviewed
Mar 1, 2024
| #include <sys/types.h> | ||
| // clang-format off |
There was a problem hiding this comment.
Please explain here with comment, why this is needed.
vitalybuka
approved these changes
Mar 1, 2024
shuffling the order of its includes.
devnexen
force-pushed
the
fuzzer_win_build_fix
branch
from
1a4c7ad to
c258569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shuffling the order of its includes.