compiler-rt: Fix cmake check for _Float16 and __bf16 #83639
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using check_c_source_compiles cmake function, main has to be
provided, otherwise while compile step will be fine but linking step
will fail as there will be no main function and test will fail and
disable building HF builtins into compiler-rt
Fixes configure errors like below
aarch64-yoe-linux-ld.lld: error: undefined symbol: main
referenced by start.S:81 (../sysdeps/aarch64/start.S:81)
/mnt/b/yoe/master/build/tmp/work/cortexa72-cortexa53-crypto-yoe-linux/compiler-rt/18.1.0/recipe-sysroot/usr/lib/Scrt1.o:(_start)
referenced by start.S:82 (../sysdeps/aarch64/start.S:82)
/mnt/b/yoe/master/build/tmp/work/cortexa72-cortexa53-crypto-yoe-linux/compiler-rt/18.1.0/recipe-sysroot/usr/lib/Scrt1.o:(_start)
aarch64-yoe-linux-clang: error: linker command failed with exit code 1 (use -v to see invocation)
kraj
force-pushed
the
kraj/compiler-rt-float16
branch
from
8e7a612 to
1e33936
Compare
|
We will need this on release/18.x branch as well. |
|
Another patch 68d8b38 ( newer than this ) has been merged so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using check_c_source_compiles cmake function, main has to be provided, otherwise while compile step will be fine but linking step will fail as there will be no main function and test will fail and disable building HF builtins into compiler-rt
Fixes configure errors like below
aarch64-yoe-linux-ld.lld: error: undefined symbol: main
referenced by start.S:81 (../sysdeps/aarch64/start.S:81)
/mnt/b/yoe/master/build/tmp/work/cortexa72-cortexa53-crypto-yoe-linux/compiler-rt/18.1.0/recipe-sysroot/usr/lib/Scrt1.o:(_start)
referenced by start.S:82 (../sysdeps/aarch64/start.S:82)
/mnt/b/yoe/master/build/tmp/work/cortexa72-cortexa53-crypto-yoe-linux/compiler-rt/18.1.0/recipe-sysroot/usr/lib/Scrt1.o:(_start)
aarch64-yoe-linux-clang: error: linker command failed with exit code 1 (use -v to see invocation)