Skip to content

[mlir][Transform] Remove notifyOperationErased workaround #84134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthias-springer
Copy link
Member

D144193 (#66771) has been merged.

@matthias-springer matthias-springer requested a review from ftynse March 6, 2024 08:10
@llvmbot llvmbot added the mlir label Mar 6, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 6, 2024

@llvm/pr-subscribers-mlir

Author: Matthias Springer (matthias-springer)

Changes

D144193 (#66771) has been merged.


Full diff: https://github.com/llvm/llvm-project/pull/84134.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp (+5-8)
diff --git a/mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp b/mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp
index 71a9d61198e3fb..fe2eea535ffdcf 100644
--- a/mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp
+++ b/mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp
@@ -1278,14 +1278,11 @@ void transform::TrackingListener::notifyMatchFailure(
 }
 
 void transform::TrackingListener::notifyOperationErased(Operation *op) {
-  // TODO: Walk can be removed when D144193 has landed.
-  op->walk([&](Operation *op) {
-    // Remove mappings for result values.
-    for (OpResult value : op->getResults())
-      (void)replacePayloadValue(value, nullptr);
-    // Remove mapping for op.
-    (void)replacePayloadOp(op, nullptr);
-  });
+  // Remove mappings for result values.
+  for (OpResult value : op->getResults())
+    (void)replacePayloadValue(value, nullptr);
+  // Remove mapping for op.
+  (void)replacePayloadOp(op, nullptr);
 }
 
 void transform::TrackingListener::notifyOperationReplaced(

@matthias-springer matthias-springer force-pushed the users/matthias-springer/pattern_listener branch from 3ecec09 to 407c7f7 Compare March 8, 2024 02:04
@matthias-springer matthias-springer force-pushed the users/matthias-springer/transform_erase_op_walk branch from d9a6a56 to 9f25fbb Compare March 8, 2024 02:07
@matthias-springer matthias-springer force-pushed the users/matthias-springer/pattern_listener branch 3 times, most recently from 24a56ca to a65d640 Compare March 8, 2024 07:26
Base automatically changed from users/matthias-springer/pattern_listener to main March 10, 2024 03:12
@matthias-springer matthias-springer force-pushed the users/matthias-springer/transform_erase_op_walk branch from 9f25fbb to efcbf90 Compare March 10, 2024 03:14
@matthias-springer matthias-springer merged commit 102273a into main Mar 15, 2024
@matthias-springer matthias-springer deleted the users/matthias-springer/transform_erase_op_walk branch March 15, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants