Skip to content

[mlir][inliner] Return early if the inliningThreshold is 0U or -1U. #86287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[mlir][inliner] Return early if the inliningThreshold is 0U or -1U. #86287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mlir/lib/Transforms/InlinerPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,19 @@ InlinerPass::InlinerPass(std::function<void(OpPassManager &)> defaultPipeline,
// Return true if the inlining ratio does not exceed the threshold.
static bool isProfitableToInline(const Inliner::ResolvedCall &resolvedCall,
unsigned inliningThreshold) {
// Return early, ratio <= 0U will always be false.
if (inliningThreshold == 0U)
return false;
// Return early, ratio <= -1U will always be true.
if (inliningThreshold == -1U)
return true;

Region *callerRegion = resolvedCall.sourceNode->getCallableRegion();
Region *calleeRegion = resolvedCall.targetNode->getCallableRegion();

// We should not get external nodes here, but just return true
// for now to preserve the original behavior of the inliner pass.
if (!calleeRegion || !calleeRegion)
if (!callerRegion || !calleeRegion)
return true;

auto countOps = [](Region *region) {
Expand Down