-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[X86_64] fix SSE type error in vaarg. #86377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 | ||
// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s | ||
|
||
|
||
typedef struct { struct {} a; } empty; | ||
|
||
// CHECK-LABEL: define dso_local void @empty_record_test( | ||
// CHECK-SAME: i32 noundef [[Z:%.*]], ...) #[[ATTR0:[0-9]+]] { | ||
// CHECK-NEXT: entry: | ||
// CHECK-NEXT: [[RETVAL:%.*]] = alloca [[STRUCT_EMPTY:%.*]], align 1 | ||
// CHECK-NEXT: [[Z_ADDR:%.*]] = alloca i32, align 4 | ||
// CHECK-NEXT: [[LIST:%.*]] = alloca [1 x %struct.__va_list_tag], align 16 | ||
// CHECK-NEXT: [[TMP:%.*]] = alloca [[STRUCT_EMPTY]], align 1 | ||
// CHECK-NEXT: store i32 [[Z]], ptr [[Z_ADDR]], align 4 | ||
// CHECK-NEXT: [[ARRAYDECAY:%.*]] = getelementptr inbounds [1 x %struct.__va_list_tag], ptr [[LIST]], i64 0, i64 0 | ||
// CHECK-NEXT: call void @llvm.va_start(ptr [[ARRAYDECAY]]) | ||
// CHECK-NEXT: [[ARRAYDECAY1:%.*]] = getelementptr inbounds [1 x %struct.__va_list_tag], ptr [[LIST]], i64 0, i64 0 | ||
// CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[RETVAL]], ptr align 1 [[TMP]], i64 0, i1 false) | ||
// CHECK-NEXT: ret void | ||
// | ||
empty empty_record_test(int z, ...) { | ||
__builtin_va_list list; | ||
__builtin_va_start(list, z); | ||
return __builtin_va_arg(list, empty); | ||
} | ||
|
||
typedef struct { | ||
struct{} a; | ||
double b; | ||
} s1; | ||
|
||
// CHECK-LABEL: define dso_local double @f( | ||
// CHECK-SAME: i32 noundef [[Z:%.*]], ...) #[[ATTR0]] { | ||
// CHECK-NEXT: entry: | ||
// CHECK-NEXT: [[RETVAL:%.*]] = alloca [[STRUCT_S1:%.*]], align 8 | ||
// CHECK-NEXT: [[Z_ADDR:%.*]] = alloca i32, align 4 | ||
// CHECK-NEXT: [[LIST:%.*]] = alloca [1 x %struct.__va_list_tag], align 16 | ||
// CHECK-NEXT: store i32 [[Z]], ptr [[Z_ADDR]], align 4 | ||
// CHECK-NEXT: [[ARRAYDECAY:%.*]] = getelementptr inbounds [1 x %struct.__va_list_tag], ptr [[LIST]], i64 0, i64 0 | ||
// CHECK-NEXT: call void @llvm.va_start(ptr [[ARRAYDECAY]]) | ||
// CHECK-NEXT: [[ARRAYDECAY1:%.*]] = getelementptr inbounds [1 x %struct.__va_list_tag], ptr [[LIST]], i64 0, i64 0 | ||
// CHECK-NEXT: [[FP_OFFSET_P:%.*]] = getelementptr inbounds [[STRUCT___VA_LIST_TAG:%.*]], ptr [[ARRAYDECAY1]], i32 0, i32 1 | ||
// CHECK-NEXT: [[FP_OFFSET:%.*]] = load i32, ptr [[FP_OFFSET_P]], align 4 | ||
// CHECK-NEXT: [[FITS_IN_FP:%.*]] = icmp ule i32 [[FP_OFFSET]], 160 | ||
// CHECK-NEXT: br i1 [[FITS_IN_FP]], label [[VAARG_IN_REG:%.*]], label [[VAARG_IN_MEM:%.*]] | ||
// CHECK: vaarg.in_reg: | ||
// CHECK-NEXT: [[TMP0:%.*]] = getelementptr inbounds [[STRUCT___VA_LIST_TAG]], ptr [[ARRAYDECAY1]], i32 0, i32 3 | ||
// CHECK-NEXT: [[REG_SAVE_AREA:%.*]] = load ptr, ptr [[TMP0]], align 16 | ||
// CHECK-NEXT: [[TMP1:%.*]] = getelementptr i8, ptr [[REG_SAVE_AREA]], i32 [[FP_OFFSET]] | ||
// CHECK-NEXT: [[TMP2:%.*]] = add i32 [[FP_OFFSET]], 16 | ||
// CHECK-NEXT: store i32 [[TMP2]], ptr [[FP_OFFSET_P]], align 4 | ||
// CHECK-NEXT: br label [[VAARG_END:%.*]] | ||
// CHECK: vaarg.in_mem: | ||
// CHECK-NEXT: [[OVERFLOW_ARG_AREA_P:%.*]] = getelementptr inbounds [[STRUCT___VA_LIST_TAG]], ptr [[ARRAYDECAY1]], i32 0, i32 2 | ||
// CHECK-NEXT: [[OVERFLOW_ARG_AREA:%.*]] = load ptr, ptr [[OVERFLOW_ARG_AREA_P]], align 8 | ||
// CHECK-NEXT: [[OVERFLOW_ARG_AREA_NEXT:%.*]] = getelementptr i8, ptr [[OVERFLOW_ARG_AREA]], i32 8 | ||
// CHECK-NEXT: store ptr [[OVERFLOW_ARG_AREA_NEXT]], ptr [[OVERFLOW_ARG_AREA_P]], align 8 | ||
// CHECK-NEXT: br label [[VAARG_END]] | ||
// CHECK: vaarg.end: | ||
// CHECK-NEXT: [[VAARG_ADDR:%.*]] = phi ptr [ [[TMP1]], [[VAARG_IN_REG]] ], [ [[OVERFLOW_ARG_AREA]], [[VAARG_IN_MEM]] ] | ||
// CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 8 [[RETVAL]], ptr align 8 [[VAARG_ADDR]], i64 8, i1 false) | ||
// CHECK-NEXT: [[TMP3:%.*]] = load double, ptr [[RETVAL]], align 8 | ||
// CHECK-NEXT: ret double [[TMP3]] | ||
// | ||
s1 f(int z, ...) { | ||
__builtin_va_list list; | ||
__builtin_va_start(list, z); | ||
return __builtin_va_arg(list, s1); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py | ||
// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s | ||
// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -x c -o - %s | FileCheck %s | ||
|
||
typedef struct { struct {} a; } empty; | ||
|
||
// CHECK-LABEL: @{{.*}}empty_record_test | ||
// CHECK-LABEL: @_Z17empty_record_testiz( | ||
// CHECK-NEXT: entry: | ||
// CHECK-NEXT: [[RETVAL:%.*]] = alloca [[STRUCT_EMPTY:%.*]], align 1 | ||
// CHECK-NEXT: [[Z_ADDR:%.*]] = alloca i32, align 4 | ||
|
@@ -14,10 +13,55 @@ typedef struct { struct {} a; } empty; | |
// CHECK-NEXT: [[ARRAYDECAY:%.*]] = getelementptr inbounds [1 x %struct.__va_list_tag], ptr [[LIST]], i64 0, i64 0 | ||
// CHECK-NEXT: call void @llvm.va_start(ptr [[ARRAYDECAY]]) | ||
// CHECK-NEXT: [[ARRAYDECAY1:%.*]] = getelementptr inbounds [1 x %struct.__va_list_tag], ptr [[LIST]], i64 0, i64 0 | ||
// CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[RETVAL]], ptr align 1 [[TMP]], i64 {{.*}}, i1 false) | ||
// CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[RETVAL]], ptr align 1 [[TMP]], i64 1, i1 false) | ||
// CHECK-NEXT: ret void | ||
// | ||
empty empty_record_test(int z, ...) { | ||
__builtin_va_list list; | ||
__builtin_va_start(list, z); | ||
return __builtin_va_arg(list, empty); | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please regenerate the CHECK lines with update_cc_test_checks.py. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
typedef struct { | ||
struct{} a; | ||
double b; | ||
} s1; | ||
|
||
// CHECK-LABEL: @_Z1fiz( | ||
// CHECK-NEXT: entry: | ||
// CHECK-NEXT: [[RETVAL:%.*]] = alloca [[STRUCT_S1:%.*]], align 8 | ||
// CHECK-NEXT: [[Z_ADDR:%.*]] = alloca i32, align 4 | ||
// CHECK-NEXT: [[LIST:%.*]] = alloca [1 x %struct.__va_list_tag], align 16 | ||
// CHECK-NEXT: store i32 [[Z:%.*]], ptr [[Z_ADDR]], align 4 | ||
// CHECK-NEXT: [[ARRAYDECAY:%.*]] = getelementptr inbounds [1 x %struct.__va_list_tag], ptr [[LIST]], i64 0, i64 0 | ||
// CHECK-NEXT: call void @llvm.va_start(ptr [[ARRAYDECAY]]) | ||
// CHECK-NEXT: [[ARRAYDECAY1:%.*]] = getelementptr inbounds [1 x %struct.__va_list_tag], ptr [[LIST]], i64 0, i64 0 | ||
// CHECK-NEXT: [[FP_OFFSET_P:%.*]] = getelementptr inbounds [[STRUCT___VA_LIST_TAG:%.*]], ptr [[ARRAYDECAY1]], i32 0, i32 1 | ||
// CHECK-NEXT: [[FP_OFFSET:%.*]] = load i32, ptr [[FP_OFFSET_P]], align 4 | ||
// CHECK-NEXT: [[FITS_IN_FP:%.*]] = icmp ule i32 [[FP_OFFSET]], 160 | ||
// CHECK-NEXT: br i1 [[FITS_IN_FP]], label [[VAARG_IN_REG:%.*]], label [[VAARG_IN_MEM:%.*]] | ||
// CHECK: vaarg.in_reg: | ||
// CHECK-NEXT: [[TMP0:%.*]] = getelementptr inbounds [[STRUCT___VA_LIST_TAG]], ptr [[ARRAYDECAY1]], i32 0, i32 3 | ||
// CHECK-NEXT: [[REG_SAVE_AREA:%.*]] = load ptr, ptr [[TMP0]], align 16 | ||
// CHECK-NEXT: [[TMP1:%.*]] = getelementptr i8, ptr [[REG_SAVE_AREA]], i32 [[FP_OFFSET]] | ||
// CHECK-NEXT: [[TMP2:%.*]] = add i32 [[FP_OFFSET]], 16 | ||
// CHECK-NEXT: store i32 [[TMP2]], ptr [[FP_OFFSET_P]], align 4 | ||
// CHECK-NEXT: br label [[VAARG_END:%.*]] | ||
// CHECK: vaarg.in_mem: | ||
// CHECK-NEXT: [[OVERFLOW_ARG_AREA_P:%.*]] = getelementptr inbounds [[STRUCT___VA_LIST_TAG]], ptr [[ARRAYDECAY1]], i32 0, i32 2 | ||
// CHECK-NEXT: [[OVERFLOW_ARG_AREA:%.*]] = load ptr, ptr [[OVERFLOW_ARG_AREA_P]], align 8 | ||
// CHECK-NEXT: [[OVERFLOW_ARG_AREA_NEXT:%.*]] = getelementptr i8, ptr [[OVERFLOW_ARG_AREA]], i32 16 | ||
// CHECK-NEXT: store ptr [[OVERFLOW_ARG_AREA_NEXT]], ptr [[OVERFLOW_ARG_AREA_P]], align 8 | ||
// CHECK-NEXT: br label [[VAARG_END]] | ||
// CHECK: vaarg.end: | ||
// CHECK-NEXT: [[VAARG_ADDR:%.*]] = phi ptr [ [[TMP1]], [[VAARG_IN_REG]] ], [ [[OVERFLOW_ARG_AREA]], [[VAARG_IN_MEM]] ] | ||
// CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 8 [[RETVAL]], ptr align 8 [[VAARG_ADDR]], i64 16, i1 false) | ||
// CHECK-NEXT: [[TMP3:%.*]] = getelementptr inbounds i8, ptr [[RETVAL]], i64 8 | ||
// CHECK-NEXT: [[TMP4:%.*]] = load double, ptr [[TMP3]], align 8 | ||
// CHECK-NEXT: ret double [[TMP4]] | ||
// | ||
s1 f(int z, ...) { | ||
__builtin_va_list list; | ||
__builtin_va_start(list, z); | ||
return __builtin_va_arg(list, s1); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is really worth testing... at least, it's not testing anything relevant to this patch. (sizeof(s1)==8.) Up to you, I guess.