[NewPM] Add FunctionToMachineFunctionPassAdaptor
#88711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
reviewed
Apr 15, 2024
| // | ||
| // Once function changed by a non-trivial pass, we need to do instruction | ||
| // selection again. | ||
| auto PAC = PA.getChecker<FunctionAnalysisManagerModuleProxy>(); |
There was a problem hiding this comment.
this returns a PreservedAnalysisChecker, so it's fine as is
aeubanks
reviewed
Apr 15, 2024
| // | ||
| // Once function changed by a non-trivial pass, we need to do instruction | ||
| // selection again. | ||
| auto PAC = PA.getChecker<FunctionAnalysisManagerModuleProxy>(); |
There was a problem hiding this comment.
this returns a PreservedAnalysisChecker, so it's fine as is
aeubanks
reviewed
Apr 15, 2024
| // If this proxy isn't marked as preserved, then even if the result remains | ||
| // valid, the key itself may no longer be valid, so we clear everything. | ||
| // | ||
| // Once function changed by a non-trivial pass, we need to do instruction |
There was a problem hiding this comment.
is this something that actually happens? I thought once we're done with codegen, we're basically done with the IR as well
There was a problem hiding this comment.
This never happened, MachineOutliner just only create dummy IR functions to get associated machine functions.
paperchalice
force-pushed
the
adaptor
branch
2 times, most recently
from
b6058e0 to
e404d6d
Compare
paperchalice
commented
Apr 16, 2024
| // Clear out the analysis manager if we're being destroyed -- it means we | ||
| // didn't even see an invalidate call when we got invalidated. | ||
| FAM->clear(); | ||
| } |
There was a problem hiding this comment.
This causes destruction issue when destruct analysis managers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
FunctionToMachineFunctionPassAdaptor, currently codegen pipeline has the patternmodule->function->machine-functionifMachineOutlinerPassis not enabled. This adaptor allowsFreeMachineFunctionto be a function pass, then we don't need to handle function analyses invalidation inMachinePassManageretc.Stacked on #88610.
Issue: #84397.