[lldb] fix python extension debug suffix on Win

[amordo]

ae389b2 change doesn't cover "_d" suffix for Debug build on Windows.

Fixed #87381.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Alexander M. (amordo)

Changes

ae389b2 change doesn't cover "_d" suffix for Debug build on Windows.

Fixed #87381.

---

Full diff: https://github.com/llvm/llvm-project/pull/89037.diff

1 Files Affected:

• (modified) lldb/bindings/python/CMakeLists.txt (+5-1)

diff --git a/lldb/bindings/python/CMakeLists.txt b/lldb/bindings/python/CMakeLists.txt
index 73b1239495e22e..183cee9ea64a06 100644
--- a/lldb/bindings/python/CMakeLists.txt
+++ b/lldb/bindings/python/CMakeLists.txt
@@ -136,7 +136,11 @@ function(finish_swig_python swig_target lldb_python_bindings_dir lldb_python_tar
   else()
     set(LIBLLDB_SYMLINK_DEST "${LLVM_SHLIB_OUTPUT_INTDIR}/liblldb${CMAKE_SHARED_LIBRARY_SUFFIX}")
   endif()
-  set(LIBLLDB_SYMLINK_OUTPUT_FILE "_lldb${LLDB_PYTHON_EXT_SUFFIX}")
+  if(WIN32 AND CMAKE_BUILD_TYPE STREQUAL Debug)
+    set(LIBLLDB_SYMLINK_OUTPUT_FILE "_lldb_d${LLDB_PYTHON_EXT_SUFFIX}")
+  else()
+    set(LIBLLDB_SYMLINK_OUTPUT_FILE "_lldb${LLDB_PYTHON_EXT_SUFFIX}")
+  endif()
   create_relative_symlink(${swig_target} ${LIBLLDB_SYMLINK_DEST}
                           ${lldb_python_target_dir} ${LIBLLDB_SYMLINK_OUTPUT_FILE})
 

[DavidSpickett]

Looks fine but can you just confirm what

llvm-project/lldb/bindings/python/get-python-config.py

Line 70 in d1a69e4

elif args.variable_name == "LLDB_PYTHON_EXT_SUFFIX":

reports?

I assume this does not include _d, otherwise there would be no need for this fix?

[DavidSpickett]

The best docs I can find are https://peps.python.org/pep-0720/:
"Interpreter-specific Python extension (native module) suffix — generally defined as .{SOABI}.{SHLIB_SUFFIX}."

Which is less than helpful. https://peps.python.org/pep-3149/ mentions Windows uses a different format.

But anyway, just curious exactly what your interpreter returns.

[amordo]

Looks fine but can you just confirm what

llvm-project/lldb/bindings/python/get-python-config.py

Line 70 in d1a69e4

elif args.variable_name == "LLDB_PYTHON_EXT_SUFFIX":

reports?
I assume this does not include _d, otherwise there would be no need for this fix?

C:\Users\iammorjj\llvm-project\lldb\bindings\python>python get-python-config.py LLDB_PYTHON_EXT_SUFFIX
.cp312-win_amd64.pyd

C:\Users\iammorjj\llvm-project\lldb\bindings\python>python_d get-python-config.py LLDB_PYTHON_EXT_SUFFIX
_d.cp312-win_amd64.pyd

Now I suppose the problem comes from

foreach(var LLDB_PYTHON_RELATIVE_PATH LLDB_PYTHON_EXE_RELATIVE_PATH LLDB_PYTHON_EXT_SUFFIX)
    if(NOT DEFINED ${var} AND NOT CMAKE_CROSSCOMPILING)
      execute_process(
        COMMAND ${Python3_EXECUTABLE}
          ${CMAKE_CURRENT_SOURCE_DIR}/bindings/python/get-python-config.py
          ${var}
        OUTPUT_VARIABLE value
        OUTPUT_STRIP_TRAILING_WHITESPACE)
      file(TO_CMAKE_PATH "${value}" value)
      set(${var} ${value} CACHE STRING ${cachestring_${var}})

where Python3_EXECUTABLE is Release python

[DavidSpickett]

This PR fixes debug lldb -> release Python, but if I configured against a debug Python then the suffix would be _d_d.

Debug lldb/release Python is a valid config I think, and likely what 99% of people want anyway. So can we add a check whether the suffix already has _d in it, so that debug lldb/debug python also works?

[amordo]

Applied @DavidSpickett's remark

[DavidSpickett]

LGTM

I can merge this for you if you don't have commit access, otherwise go ahead and merge it yourself.

[amordo]

@DavidSpickett I have no write privilege, so, please, merge it:)