Skip to content

Revert "CompilerRT: Normalize COMPILER_RT_DEFAULT_TARGET_TRIPLE" #89150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "CompilerRT: Normalize COMPILER_RT_DEFAULT_TARGET_TRIPLE" #89150

wants to merge 1 commit into from

Conversation

ZijunZhaoCCK
Copy link
Contributor

Reverts #88835

Break the build:

  Host compiler does not support '-fuse-ld=lld'.  Please make sure that 'lld'
  is installed and that your host compiler can compile a simple program when
  given the option '-fuse-ld=lld'.

@DavidSpickett
Copy link
Collaborator

I reverted it myself, 3da0658.

Please comment on #88835 with more details of the failure you were seeing so we can make sure it gets addressed.

@DavidSpickett DavidSpickett deleted the revert-88835-cmake-clang-rt-dir branch April 18, 2024 10:54
@wzssyqa
Copy link
Contributor

wzssyqa commented Apr 18, 2024

@ZijunZhaoCCK How to reproduce this problem?

@wzssyqa wzssyqa mentioned this pull request Apr 19, 2024
Merged
@ZijunZhaoCCK
Copy link
Contributor Author

@ZijunZhaoCCK How to reproduce this problem?

I was doing some internal tests and it broke the build. Yesterday we found a possible bug in our internal build script. So no need to reproduce, we should fix our build script to be compatible with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZijunZhaoCCK @DavidSpickett @wzssyqa