[clang-tidy][NFC] Fix broken link in documentation of cert-env33-c #90216
Conversation
It seems that the description of the SEI CERT rules was moved from `www.securecoding.cert.org` to `wiki.sei.cmu.edu` and the page IDs were not preserved during the transition. However, the old domain name redirects to the new one and permalinks derived from the name of the rule still work, so I kept using the old domain name to be consistent with other documentation files using it.
|
@llvm/pr-subscribers-clang-tools-extra Author: None (NagyDonat) ChangesIt seems that the description of the SEI CERT rules was moved from However, the old domain name redirects to the new one and permalinks derived from the name of the rule still work, so I kept using the old domain name to be consistent with other documentation files using it. Full diff: https://github.com/llvm/llvm-project/pull/90216.diff 1 Files Affected:
diff --git a/clang-tools-extra/docs/clang-tidy/checks/cert/env33-c.rst b/clang-tools-extra/docs/clang-tidy/checks/cert/env33-c.rst
index c5321b07f7f84d..9271c9ecccc00c 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/cert/env33-c.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/cert/env33-c.rst
@@ -10,4 +10,4 @@ but does not actually attempt to execute a command.
This check corresponds to the CERT C Coding Standard rule
`ENV33-C. Do not call system()
-<https://www.securecoding.cert.org/confluence/pages/viewpage.action?pageId=2130132>`_.
+<https://www.securecoding.cert.org/confluence/display/c/ENV33-C.+Do+not+call+system()>`_.
|
|
@llvm/pr-subscribers-clang-tidy Author: None (NagyDonat) ChangesIt seems that the description of the SEI CERT rules was moved from However, the old domain name redirects to the new one and permalinks derived from the name of the rule still work, so I kept using the old domain name to be consistent with other documentation files using it. Full diff: https://github.com/llvm/llvm-project/pull/90216.diff 1 Files Affected:
diff --git a/clang-tools-extra/docs/clang-tidy/checks/cert/env33-c.rst b/clang-tools-extra/docs/clang-tidy/checks/cert/env33-c.rst
index c5321b07f7f84d..9271c9ecccc00c 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/cert/env33-c.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/cert/env33-c.rst
@@ -10,4 +10,4 @@ but does not actually attempt to execute a command.
This check corresponds to the CERT C Coding Standard rule
`ENV33-C. Do not call system()
-<https://www.securecoding.cert.org/confluence/pages/viewpage.action?pageId=2130132>`_.
+<https://www.securecoding.cert.org/confluence/display/c/ENV33-C.+Do+not+call+system()>`_.
|
|
If there is redirection, then we could switch all links to new domain. |
|
I'm merging this now, because switching all links to the new domain name has no immediate advantages (as long as the current one works) and would touch a dozen additional files. (By the way, the currently used domain name is also referenced in a LICENSE.TXT file and I didn't want to touch that.) |
It seems that the description of the SEI CERT rules was moved from
www.securecoding.cert.orgtowiki.sei.cmu.eduand the page IDs were not preserved during the transition.However, the old domain name redirects to the new one and permalinks derived from the name of the rule still work, so I kept using the old domain name to be consistent with other documentation files using it.