Skip to content

[lldb][sbapi] Fix API break in SBDebugger broadcast bits #90261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chelcassanova
Copy link
Contributor

#87409 removed the broadcast bits from SBDebugger and placed them in lldb-enumerations.h. This is API-breaking so this commits places the enum back into SBDebugger.h and references the bits from lldb-enumerations.h.

@llvmbot
Copy link
Member

llvmbot commented Apr 26, 2024

@llvm/pr-subscribers-lldb

Author: Chelsea Cassanova (chelcassanova)

Changes

#87409 removed the broadcast bits from SBDebugger and placed them in lldb-enumerations.h. This is API-breaking so this commits places the enum back into SBDebugger.h and references the bits from lldb-enumerations.h.


Full diff: https://github.com/llvm/llvm-project/pull/90261.diff

1 Files Affected:

  • (modified) lldb/include/lldb/API/SBDebugger.h (+7)
diff --git a/lldb/include/lldb/API/SBDebugger.h b/lldb/include/lldb/API/SBDebugger.h
index cf5409a12a056a..7333cd57ad3129 100644
--- a/lldb/include/lldb/API/SBDebugger.h
+++ b/lldb/include/lldb/API/SBDebugger.h
@@ -42,6 +42,13 @@ class LLDB_API SBInputReader {
 
 class LLDB_API SBDebugger {
 public:
+  FLAGS_ANONYMOUS_ENUM(){
+      eBroadcastBitProgress = lldb::DebuggerBroadcastBit::eBroadcastBitProgress,
+      eBroadcastBitWarning = lldb::DebuggerBroadcastBit::eBroadcastBitWarning,
+      eBroadcastBitError = lldb::DebuggerBroadcastBit::eBroadcastBitError,
+      eBroadcastBitProgressCategory =
+          lldb::DebuggerBroadcastBit::eBroadcastBitProgressCategory,
+  };
   SBDebugger();
 
   SBDebugger(const lldb::SBDebugger &rhs);

llvm#87409 removed the broadcast
bits from SBDebugger and placed them in `lldb-enumerations.h`. This is
API-breaking so this commits places the enum back into `SBDebugger.h`
and references the bits from `lldb-enumerations.h`.
@chelcassanova chelcassanova force-pushed the fix-sbdebugger-broadcast-bits branch from b0a7237 to 697ab92 Compare April 26, 2024 20:15
@chelcassanova chelcassanova merged commit a4c21d1 into llvm:main Apr 26, 2024
4 checks passed
@chelcassanova chelcassanova deleted the fix-sbdebugger-broadcast-bits branch April 26, 2024 20:18
chelcassanova added a commit to chelcassanova/llvm-project that referenced this pull request Apr 26, 2024
llvm#87409 removed the broadcast
bits from SBDebugger and placed them in `lldb-enumerations.h`. This is
API-breaking so this commits places the enum back into `SBDebugger.h`
and references the bits from `lldb-enumerations.h`.

rdar://127128536
(cherry picked from commit a4c21d1)
JDevlieghere added a commit to swiftlang/llvm-project that referenced this pull request Apr 29, 2024
…-bits

[lldb][sbapi] Fix API break in SBDebugger broadcast bits (llvm#90261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants