Skip to content

[flang] cmake fix for FLANG_RUNTIME_F128_MATH_LIB build #93054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

dpalermo
Copy link
Contributor

Remove an extra '-D' in the call to add_compile_definitions. The extra -D causes -D-DFLANG_RUNTIME_F128_MATH_LIB=libquadmath to appear in compile options which results in a compilation failure. This occurs only on systems using cmake versions 3.22.1 or 3.24.3. Using cmake 3.28.1 seems to automatically remove the duplicate -D.

Fixes #81971

Remove an extra '-D' in the call to add_compile_definitions.
The extra -D causes -D-DFLANG_RUNTIME_F128_MATH_LIB=libquadmath to
appear in compile options which results in a compilation failure.
This occurs only on systems using cmake versions 3.22.1 or 3.24.3.
Using cmake 3.28.1 seems to automatically remove the duplicate -D.

Fixes llvm#81971
@dpalermo dpalermo requested review from mjklemm and vzakhari May 22, 2024 15:34
@llvmbot llvmbot added the flang Flang issues not falling into any other category label May 22, 2024
Copy link
Contributor

@vzakhari vzakhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@mjklemm mjklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dpalermo dpalermo merged commit 47ed2bf into llvm:main May 22, 2024
5 of 6 checks passed
@dpalermo dpalermo deleted the dpalermo_f128_cmake branch May 22, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants