Skip to content

Conversation

Sirraide
Copy link
Member

The parameter of getAddress() was not being used, as I recall, and seems to have been removed in the meantime. Merging this w/o review since this is breaking builds.

@Sirraide Sirraide merged commit da88e7f into llvm:main May 22, 2024
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:codegen IR generation bugs: mangling, exceptions, etc. labels May 22, 2024
@llvmbot
Copy link
Member

llvmbot commented May 22, 2024

@llvm/pr-subscribers-clang-codegen

@llvm/pr-subscribers-clang

Author: None (Sirraide)

Changes

The parameter of getAddress() was not being used, as I recall, and seems to have been removed in the meantime. Merging this w/o review since this is breaking builds.


Full diff: https://github.com/llvm/llvm-project/pull/93086.diff

1 Files Affected:

  • (modified) clang/lib/CodeGen/CGExpr.cpp (+1-1)
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index 4c4a42134dd4a..4072025376768 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -4701,7 +4701,7 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const FieldDecl *Field,
     if (ThisTy != LambdaTy) {
       const CXXCastPath &BasePathArray = getContext().LambdaCastPaths.at(MD);
       Address Base = GetAddressOfBaseClass(
-          LambdaLV.getAddress(*this), ThisTy, BasePathArray.begin(),
+          LambdaLV.getAddress(), ThisTy, BasePathArray.begin(),
           BasePathArray.end(), /*NullCheckValue=*/false, SourceLocation());
       LambdaLV = MakeAddrLValue(Base, QualType{LambdaTy->getTypeForDecl(), 0});
     }

@efriedma-quic
Copy link
Collaborator

Looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:codegen IR generation bugs: mangling, exceptions, etc. clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants