Skip to content

InterleavedLoadCombine: Correctly query PM for TargetTransformInfo #93103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

InterleavedLoadCombine: Correctly query PM for TargetTransformInfo #93103

merged 1 commit into from
May 23, 2024

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented May 22, 2024

No description provided.

@arsenm arsenm mentioned this pull request May 22, 2024
Merged
aeubanks
aeubanks approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@aeubanks aeubanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the plan to remove getTargetTransformInfo()?

@arsenm
Copy link
Contributor Author

arsenm commented May 23, 2024

is the plan to remove getTargetTransformInfo()?

It needs to be constructed from somewhere, maybe? This shouldn't be publicly visible at least

@arsenm arsenm merged commit 7f5c71e into llvm:main May 23, 2024
@arsenm arsenm deleted the interleaved-load-combine-tti-query branch May 23, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeubanks aeubanks aeubanks approved these changes

@paperchalice paperchalice Awaiting requested review from paperchalice

@Pierre-vh Pierre-vh Awaiting requested review from Pierre-vh

@kazutakahirata kazutakahirata Awaiting requested review from kazutakahirata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arsenm @aeubanks