Skip to content

fix(mlir/**.py): fix comparison to None #94019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix(mlir/**.py): fix comparison to None #94019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/test/python/ir/affine_expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def testAffineExprEq():
# CHECK: False
print(a1 == a3)
# CHECK: False
print(a1 == None)
print(a1 is None)
# CHECK: False
print(a1 == "foo")

Expand Down
8 changes: 4 additions & 4 deletions mlir/test/python/ir/attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ def testAttrEq():
print("a1 == a2:", a1 == a2)
# CHECK: a1 == a3: True
print("a1 == a3:", a1 == a3)
# CHECK: a1 == None: False
print("a1 == None:", a1 == None)
# CHECK: a1 is None: False
print("a1 is None:", a1 is None)


# CHECK-LABEL: TEST: testAttrHash
Expand Down Expand Up @@ -109,9 +109,9 @@ def testAttrEqDoesNotRaise():
# CHECK: False
print(a1 == not_an_attr)
# CHECK: False
print(a1 == None)
print(a1 is None)
# CHECK: True
print(a1 != None)
print(a1 is not None)


# CHECK-LABEL: TEST: testAttrCapsule
Expand Down
8 changes: 4 additions & 4 deletions mlir/test/python/ir/builtin_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def testTypeEq():
print("t1 == t2:", t1 == t2)
# CHECK: t1 == t3: True
print("t1 == t3:", t1 == t3)
# CHECK: t1 == None: False
print("t1 == None:", t1 == None)
# CHECK: t1 is None: False
print("t1 is None:", t1 is None)


# CHECK-LABEL: TEST: testTypeHash
Expand Down Expand Up @@ -143,9 +143,9 @@ def testTypeEqDoesNotRaise():
# CHECK: False
print(t1 == not_a_type)
# CHECK: False
print(t1 == None)
print(t1 is None)
# CHECK: True
print(t1 != None)
print(t1 is not None)


# CHECK-LABEL: TEST: testTypeCapsule
Expand Down