[NewPM][BPF] Add BPFCodeGenPassBuilder
#94158
Conversation
We need a simple enough target to make codegen pipeline as short as possible.
No, how to extend the codegen pipeline is still controversial. It seems that using callback functions is better than polymorphic member function. |
can you clarify your comment? we're trying to make codegen work with the new pass manager |
all TODO are screaming that this is useless change. |
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This file implements BPFCodeGenPassBuilder class. |
There was a problem hiding this comment.
I'd remove this comment, it's not very useful
because we're going to implement them in a followup change this PR is just boilerplate and doesn't actually do much. however, it makes follow-up changes smaller which is valuable for reviewing |
Not really. At present this is pointless code churn and nothing else. Make a meaningful diff and describe the reasons to make it. |
We need a simple enough target to make codegen pipeline short, so we can handle important passes (e.g. asm printer) as soon as possible.