[CodeGen][NewPM] Port machine dominator tree analysis to new pass manager #95879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperchalice
requested review from
arsenm and
aeubanks
and removed request for
arsenm
arsenm
reviewed
Jun 18, 2024
Comment on lines
66
to
68
| return !(PAC.preserved() || | ||
| PAC.preservedSet<AllAnalysesOn<MachineFunction>>() || | ||
| PAC.preservedSet<CFGAnalyses>()); |
| PreservedAnalyses | ||
| MachineDominatorTreePrinterPass::run(MachineFunction &MF, | ||
| MachineFunctionAnalysisManager &MFAM) { | ||
| OS << "MachineDominatorTree for machine function: " << MF.getName() << '\n'; |
There was a problem hiding this comment.
This follows DominatorTreePrinterPass:
llvm-project/llvm/lib/IR/Dominators.cpp
Lines 384 to 385 in 4b4aaf1
- Add `MachineDominatorTreeAnalysis` - Add `MachineDominatorTreePrinterPass` There is no test for this analysis in codebase. Also, the pass name is renamed to `machine-dom-tree` instead of `machinedomtree`.
arsenm
approved these changes
Jun 18, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/151/builds/285 Here is the relevant piece of the build log for the reference: |
paperchalice
added a commit
to paperchalice/llvm-project
that referenced
this pull request
Jun 22, 2024
…s manager Follows llvm#95879.
paperchalice
added a commit
to paperchalice/llvm-project
that referenced
this pull request
Jun 22, 2024
…s manager Follows llvm#95879.
paperchalice
added a commit
to paperchalice/llvm-project
that referenced
this pull request
Jun 22, 2024
…s manager Follows llvm#95879.
paperchalice
added a commit
to paperchalice/llvm-project
that referenced
this pull request
Jun 22, 2024
…s manager Follows llvm#95879.
21 tasks
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
…ager (llvm#95879) - Add `MachineDominatorTreeAnalysis` - Add `MachineDominatorTreePrinterPass` There is no test for this analysis in codebase. Also, the pass name is renamed to `machine-dom-tree` instead of `machinedomtree`.
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
…s manager (llvm#96378) Follows llvm#95879.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MachineDominatorTreeAnalysisMachineDominatorTreePrinterPassThere is no test for this analysis in codebase.Also, the pass name is renamed to
machine-dom-treeinstead ofmachinedomtree.