[ADT] DenseMapInfo<unsigned long>::getHashValue - avoid MSVC out of bounds shift warning

[RKSimon]

Fixes MSVC warning after #95734 - despite it taking the sizeof(Val) == 4 path, it still warns that the 32-bit unsigned long shift by 32 is out of bounds.

[llvmbot]

@llvm/pr-subscribers-llvm-adt

Author: Simon Pilgrim (RKSimon)

Changes

Fixes MSVC warning after #95734 - despite it taking the sizeof(Val) == 4 path, it still warns that the 32-bit unsigned long shift by 32 is out of bounds, so avoid it by converting the hard coded shift amount to be based off sizeof() instead.

---

Full diff: https://github.com/llvm/llvm-project/pull/96173.diff

1 Files Affected:

• (modified) llvm/include/llvm/ADT/DenseMapInfo.h (+1-1)

diff --git a/llvm/include/llvm/ADT/DenseMapInfo.h b/llvm/include/llvm/ADT/DenseMapInfo.h
index 4f0aaa1ad48bb..3d83a2c1473f5 100644
--- a/llvm/include/llvm/ADT/DenseMapInfo.h
+++ b/llvm/include/llvm/ADT/DenseMapInfo.h
@@ -142,7 +142,7 @@ template<> struct DenseMapInfo<unsigned long> {
     if constexpr (sizeof(Val) == 4)
       return DenseMapInfo<unsigned>::getHashValue(Val);
     else
-      return detail::combineHashValue(Val >> 32, Val);
+      return detail::combineHashValue(Val >> (4 * sizeof(Val)), Val);
   }
 
   static bool isEqual(const unsigned long& LHS, const unsigned long& RHS) {

[ChuanqiXu9]

Thanks

[AaronBallman]

LGTM

[RKSimon]

Thank you everyone