[OpenMP][OMPT] Indicate loop schedule for worksharing-loop events #97429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use more specific values from `ompt_work_t` to allow the tool identify the schedule of a worksharing-loop. With this patch, the runtime will report the schedule chosen by the runtime rather than necessarily the schedule literally requested by the clause. E.g., for guided + just one iteration per thread, the runtime would choose static. Fixes issue llvm#63904
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Thanks a lot for the PR. I've looked through our internal OpenMP CI. No test reports |
hansangbae
reviewed
Jul 2, 2024
openmp/runtime/src/ompt-specific.h
Outdated
| @@ -130,6 +130,28 @@ inline const char *ompt_get_runtime_version() { | |||
| return &__kmp_version_lib_ver[KMP_VERSION_MAGIC_LEN]; | |||
| } | |||
|
|
|||
| inline ompt_work_t ompt_get_work_schedule(enum sched_type schedule){ | |||
| printf("Schedule val: %i\n", schedule); | |||
There was a problem hiding this comment.
Can you remove the printf statement if it is not intended?
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
…vm#97429) Use more specific values from `ompt_work_t` to allow the tool identify the schedule of a worksharing-loop. With this patch, the runtime will report the schedule chosen by the runtime rather than necessarily the schedule literally requested by the clause. E.g., for guided + just one iteration per thread, the runtime would choose and report static. Fixes issue llvm#63904
kbluck
pushed a commit
to kbluck/llvm-project
that referenced
this pull request
Jul 6, 2024
…vm#97429) Use more specific values from `ompt_work_t` to allow the tool identify the schedule of a worksharing-loop. With this patch, the runtime will report the schedule chosen by the runtime rather than necessarily the schedule literally requested by the clause. E.g., for guided + just one iteration per thread, the runtime would choose and report static. Fixes issue llvm#63904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more specific values from
ompt_work_tto allow the tool identify the schedule of a worksharing-loop. With this patch, the runtime will report the schedule chosen by the runtime rather than necessarily the schedule literally requested by the clause.E.g., for guided + just one iteration per thread, the runtime would choose and report static.
Fixes issue #63904