Skip to content

[BOLT] Drop BOLT_CLANG_EXE #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

[BOLT] Drop BOLT_CLANG_EXE #182

merged 1 commit into from
Apr 26, 2024

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Apr 26, 2024 •
edited
Loading

As a follow-up to the issue unearthed by
llvm/llvm-project#89693, remove all uses of
BOLT_CLANG_EXE to prevent similar blockers in the future and reduce builder
maintenance overhead.

@aaupov aaupov requested review from MaskRay and gkistanova April 26, 2024 15:56
MaskRay
MaskRay approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@MaskRay MaskRay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I guess build bots use ninja all. If adding clang builds too many executables, perhaps explicit ninja clang will help.

@aaupov
Copy link
Contributor Author

aaupov commented Apr 26, 2024

Thanks!

I guess build bots use ninja all. If adding clang builds too many executables, perhaps explicit ninja clang will help.

No, BOLT buildbots are configured to only run ninja check-bolt.

@aaupov aaupov merged commit 438da05 into llvm:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaskRay MaskRay MaskRay approved these changes

@gkistanova gkistanova Awaiting requested review from gkistanova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaupov @MaskRay