[s390x] Make stage 2 builder use clean builds #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use clean builds for the s390x multistage builder as was done for Linaro in llvm#306. This will enable collapsing build requests to help the builder keep up. As further speed-up, skip the stage 1 testing, as is already done for most other multistage builders.
DavidSpickett
approved these changes
May 20, 2025
There was a problem hiding this comment.
I see -DLLVM_CCACHE_BUILD=ON in the stage 1 configuration, so this shouldn't add much if any overhead, and https://lab.llvm.org/buildbot/#/builders/42 covers the stage 1 testing already.
LGTM.
|
#250 was the origin of this. We never did find out why it was not an issue before then, I suspect it should have been an issue, but for a bug elsewhere possibly in Buildbot itself that got fixed at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use clean builds for the s390x multistage builder as was done for Linaro in #306. This will enable collapsing build requests to help the builder keep up.
As further speed-up, skip the stage 1 testing, as is already done for most other multistage builders.