Add asdouble test
#353
Open
Add asdouble test
#353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob80905
reviewed
Aug 14, 2025
| 0x000000001A9FBE77, 0x4090000000000000, 0x3FF6A09E6DC9C883, 0x3FD5555555555555, | ||
| 0X0000000000000000, 0x3FF0000000000000, 0xBFF0000000000000, 0x400921FB54442D18 | ||
| ] | ||
| # 0, 1.0, -1.0, 3.14159, 2.71828, -2.71828, 1.79769e+308, -1.79769e+308, denorm, 1024.0, 1.41421, 0.33333, 0, 1.0, -1.0, 3.14159 |
There was a problem hiding this comment.
Might be mistaken, but I thought we wanted to avoid denorm testing?
There was a problem hiding this comment.
Yeah, but I wanted to add a test where all the high bits were 0, which makes the output a denorm. Thought it would be fine because the inputs aren't denorms? But let me know your thoughts
There was a problem hiding this comment.
True, the denorm isn't an input. And I would think the output should be driver-implementation-agnostic, it's literally just putting two strings of bits together.
I think this should be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115.
Adds test for
asdoubletestinguint. I used hex format for the input/output values so the operation would be easier to visualize.Need to remove XFAILs after #153513 and #7699 are fixed.