Add LIT capabilibies for vulkan extensions #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to conditionalize tests based on available vulkan extensions. Since a set of our tests depend on float_controls2 when compiled with Clang, this allows those tests to pass if run on a device with flaot_controls2 support. The one additional tweak in this PR is to adjust the dot.fp16 test to have a wider tolerance range. DXC constant evaluates at a higher accuracy than the hardware evaluates at and our test assumes constant folded computation for the expected value. An ULP of 30 is wide enough to handle both the fp16 "correct" value and the wider computed value with rounding errors compounded.
hekota
approved these changes
Aug 18, 2025
bob80905
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to conditionalize tests based on available vulkan extensions. Since a set of our tests depend on float_controls2 when compiled with Clang, this allows those tests to pass if run on a device with flaot_controls2 support.
The one additional tweak in this PR is to adjust the dot.fp16 test to have a wider tolerance range. DXC constant evaluates at a higher accuracy than the hardware evaluates at and our test assumes constant folded computation for the expected value. An ULP of 30 is wide enough to handle both the fp16 "correct" value and the wider computed value with rounding errors compounded.