Skip to content

[TORCH] Add aten.logaddexp & aten.logaddexp2 ops support #4201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zahidwx
Copy link
Contributor

@zahidwx zahidwx commented May 23, 2025

This PR takes care of #4194

  • e2e support for aten.logaddexp and aten.logaddexp2 ops by decomposing to primitive ops having existing support in torch-mlir.
  • Added relevant expected fails in xfail_sets.py

@zahidwx zahidwx changed the title Add aten.logaddexp & aten.logaddexp2 ops support [TORCH] Add aten.logaddexp & aten.logaddexp2 ops support May 23, 2025
@zahidwx zahidwx marked this pull request as ready for review May 23, 2025 19:45
@zahidwx
Copy link
Contributor Author

zahidwx commented May 23, 2025

Would be great if someone can review it - @penguin-wwy | @vivekkhandelwal1 | @zjgarvey

@penguin-wwy
Copy link
Collaborator

Please resolve conflicts

@zahidwx zahidwx force-pushed the feature/logaddexp_logaddexp2 branch from 4526d39 to d933e03 Compare May 27, 2025 19:33
Combine new op creation & old op replacement

Signed-off-by: Zahid Wakeel <[email protected]>
@zahidwx
Copy link
Contributor Author

zahidwx commented May 27, 2025

Thanks for the review @vivekkhandelwal1 & @penguin-wwy. Resolved conflicts & addressed comments.

@zahidwx zahidwx requested a review from vivekkhandelwal1 June 1, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants