Skip to content

Change mode of bootstrap file to 0755 if not executable #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Jul 6, 2023

Motivation

This should resolve Permission denied errors we were seeing when people, most notably on non-unix platforms, uploaded lambda zip files without executable permissions on the bootstrap file.

Changes

  • If a bootstrap file (no distinction which, but the default ones in the image should always be executable) is not executable, it will set the permissions to 755, to ensure it executable under all users. If this is not possible, it will log a warning.

@dfangl dfangl requested a review from dominikschubert July 6, 2023 15:28
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfangl dfangl merged commit e4d28d8 into localstack Jul 6, 2023
@dfangl dfangl deleted the set-bootstrap-executable branch July 6, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants