Set default codec to json, update documentation. #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Between versions `1.0.4` and `1.0.5`, [this commit](logstash-plugins@c60e0ae) was added and the [default codec](https://github.com/logstash-plugins/logstash-input-google_pubsub/blob/master/lib/logstash/inputs/google_pubsub.rb#L217) began to be respected. This results in json messages being treated as `plain`, which wraps the consumed json event in the event's `message` field, and elasticsearch doesn't properly parse the event into fields. This commit changes the default type to `json` as that is the assumed default format anyway. Alternate codecs can be used by adding a codec attribute to the input plugin's configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between versions
1.0.4and1.0.5, this commit was added andthe default codec began to be respected. This results in json messages
being treated as
plain, which wraps the consumed json event in the event'smessagefield, and elasticsearch doesn't properly parse the event into fields.This commit changes the default type to
json, as that is the assumed default format anyway. Alternate codecs can be used by adding a codec attribute to the input plugin's configuration.