-
Notifications
You must be signed in to change notification settings - Fork 384
Problems with liquid include parameters containing non-Western characters #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Setogit @eddiemonge @cfjedimaster @joesepi Would appreciate any help based on your Jekyll experience. To repro, just copy/paste above into any page in the repo and then follow instructions in the README... Thanks! |
I think this is an issue with Liquid. This may be related? Shopify/liquid#31 I'm on my phone so I am not able to test. |
Thanks @joesepi This may indeed be the source of the issue. Need to see if we can come up with a workaround, or if we're just hosed. :-( |
OK, it turns out that the issue is the liquid variable The good news is that we can move forward with localization plans. |
I ran into a roadblock working on #37. Jekyll/Liquid generates an error when processing includes with non-Western parameter values, e.g.
The error is:
The English content makes extensive use of Liquid includes (with parameters) for alerts and numerous other things. So we need to resolve this or find a workaround, otherwise it's going to be much more difficult to provide translations of the docs.
The text was updated successfully, but these errors were encountered: