Skip to content

Documentation fixes #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2017
Merged

Documentation fixes #364

merged 6 commits into from
Apr 25, 2017

Conversation

b1az
Copy link
Contributor

@b1az b1az commented Apr 22, 2017

Minor improvements for LB3 docs.

@slnode
Copy link
Contributor

slnode commented Apr 22, 2017

Can one of the admins verify this patch?

@b1az
Copy link
Contributor Author

b1az commented Apr 22, 2017

2a939b8 should address #363.

@crandmck
Copy link
Contributor

Thanks @b1az for catching all these!
Only one thing isn't obvious: Why did you remove the video from Managing users?

@b1az
Copy link
Contributor Author

b1az commented Apr 24, 2017

@crandmck, I explained the video removal in the commit message:

Its bad audio quality casts a negative light on LoopBack

I'll drop this commit if you want this video to stay.

(I do see the value of having some videos interspersed in the docs, but didn't dare pick a worthy replacement myself.)

@crandmck
Copy link
Contributor

OK, sorry I didn't notice the commit message....

I think you're right, the audio is bad. So, I'm OK with removing it.
Thanks!

@crandmck crandmck merged commit ef0e8ec into loopbackio:gh-pages Apr 25, 2017
@crandmck crandmck mentioned this pull request May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants