-
Notifications
You must be signed in to change notification settings - Fork 384
Converted Chinese Documentation (zh) #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted Chinese Documentation (zh) #74
Conversation
Can one of the admins verify this patch? |
product: LoopBack - 中文 | ||
home_url: /doc/zh/lb2/index.html | ||
folders: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the format of this file in #73 but the difference is not major, just a couple substitutions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review and merge your PR asap. Then, we'll have to rework these sidebars before merging this new Chinese content. Just finishing up something else atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crandmck, any actions required on my side to solve the merge conflict ?
Hi @marc-ed-raffalli Sorry for the delay. It doesn't run "as is". Jekyll gives this error:
I think these errors are caused by the image includes, e.g.
Because the image files referenced are not there. What happened is that the export created files with different names for the images (even though they are actually the same images as used in
Also, could you please update the sidebar |
no problem. |
You'll need to update the structure (ie. the format) of the The only issue is that we've reorganized the English sidebar somewhat, so ideally we'd replace the untranslated part of the sidebar with the corresponding section of the en sidebar (replacing The most important part is just getting the Chinese content in there in some form...and of course, not breaking the site :-) I suspect we really need a Chinese-speaker to go through and clean it up to really get it in shape. Maybe once we have the basic content in place, someone will step up.... |
I went to rebase this onto gh-pages & fix the sidebar menu but there are problems building the pages from the markdown.
It appears to not like putting |
Ok, I'll look at this once I finish this picture merging. As a temporary solution, I can hard code |
0f0951b
to
0330f3c
Compare
0330f3c
to
0a40a0e
Compare
0a40a0e
to
529d1fc
Compare
Sorry, I should have mentioned this sooner... Yes, you cannot have a liquid variable in an include parameter. I've addressed this elsewhere by simply removing the In fact, I thought about removing |
Ok, I removed nested As this scenario might occur again and is quite time consuming, here's what I found quite time efficient:
|
Wow @marc-ed-raffalli you've gone above and beyond. I know that was very tedious, so THANK YOU. Getting the old translations over to the new site has been much more work than I had anticipated! It's late here now (and I've had a couple glasses of wine ;) so I'm not going to merge this now, but I will tomorrow. Thanks again. |
No problem @crandmck, you can merge whenever you get a chance. |
We can definitely send you some swag! Just send me your mailing address (to [email protected]), and we'll get something to you asap! |
Added raw converted content and side bar.
The original file name is used when it contains chinese / special chars.