Create migration-guide.md #3
Conversation
migration-guide.md
Outdated
| ## From `dart:io` | ||
|
|
||
| The `dart:io` core library is a special custom library only available on Dart | ||
| native platforms (and for example, not available on Dart web platforms). We |
There was a problem hiding this comment.
I'd make a newline before "We", to make reading the source easier. (Semantic line-breaks FTW!)
migration-guide.md
Outdated
| ```dart | ||
| import 'package:platform/platform.dart'; // version 4.x | ||
|
|
||
| bool onAndroid = Platform.current.isAndroid; |
There was a problem hiding this comment.
Should actually be
import 'package:platform/host.dart';
bool onAndroid = HostPlatform.current.isAndroid;The platform.dart library is not cross-platform capable, it's there for backwards compatibility with v3, where platform.dart allowed access to native-only features.
So, the question is whether this is a minimal migration guide or a full migration guide.
The migration shown here is the minimal needed to preserve the current behavior, including the dependency on dart:io.
The one I wrote above is the ultimate migration, to cross-platform compatible code.
Which one do we want? Both?
There was a problem hiding this comment.
I would like it if we could do the full migration to HostPlatform, but whether that is realistic I think depends on whether dart fix can automate the migration. I'm going to share this page with the analyzer team to get their input.
|
Can we merge @lrhn (this is your repo, so I can't do it) ? |
One last fix.
No description provided.