Skip to content

tests: Invert comments on pattern trailer handling, extend test values #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

huntie
Copy link
Contributor

@huntie huntie commented Dec 20, 2022

Hey, I've been looking through the tests for this library and spotted something which I'd interpreted differently in the spec. Specifically, the behaviour of pattern trailers for subpath exports, described in more detail here: nodejs/node#39635.

Changes:

  • Change the two relevant comments in tests
  • Extend test values for subpath exports to include an intermediate subdirectory

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (587b0ba) to head (e0a914b).
Report is 56 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           51        52    +1     
=========================================
+ Hits            51        52    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants