Skip to content

Plugin. WIP 1 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Plugin. WIP 1 #75

wants to merge 4 commits into from

Conversation

TIMONz1535
Copy link

@TIMONz1535 TIMONz1535 commented Jan 27, 2025

Discussion #74

  • Uses OnTransformAst.
  • NetworkVar/NetworkVarElement. It only works in sent file inside of ENT:SetupDataTables for self:NetworkVar(...) and self.NetworkVar(self, ...) for stack defined arguments, not localized one.
    Doesn't support BaseClass.SetupDataTables(self).

Now everyone can use it.

I still had to leave the line insertion local ENT\n\n by OnSetText at the sent file beginning, because I did not find a way to do this after the file was compiled by the VM (that is, inside OnTransformAst).

I haven't checked the performance, but I'm not doing any terrible things, just the minimum necessary ones.

@TIMONz1535 TIMONz1535 changed the title Plugin. WIP Plugin. WIP 1 Jan 27, 2025
@luttje luttje marked this pull request as draft January 28, 2025 13:29
@luttje
Copy link
Owner

luttje commented Jan 28, 2025

Awesome work! I'm converting this to a draft for now, so you can let me know when I can review it by turning it back into a full PR.

Thanks so much for this work, it'll greatly improve the experience for us all in VSCode!

@luttje luttje added the enhancement New feature or request label Jan 28, 2025
@TIMONz1535
Copy link
Author

Well, I meant that this version can be used publicly (like a beta), it is cleaned up, but has a limited set of features. I made a couple of typos, but I fixed them.

To do all the others features, I will need... eh months. I don't know.
I'd like you to review it and test, maybe give me some feedback.

But if you don't like beta, I won't insist.

@luttje luttje marked this pull request as ready for review January 28, 2025 22:30
@luttje luttje self-requested a review January 28, 2025 22:30
Copy link
Owner

@luttje luttje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this. Besides two issues it works as expected. I've commented on those issues in my review, could you let me know if you experience them too and if they're easy to fix?

If it's hard to fix the two issues, or you don't have time to fix them, then I'm alright to merge this into main as an experimental plugin. We can just make note of those issues and fix them in the future.

I really appreciate the work you've done here. Even with your example I still have no idea how LuaLS plugins are supposed to function, so we couldn't do this without your help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants