Skip to content

Conversation

pedropaulovc
Copy link
Contributor

Add assemblies strong-names with a new .snk file generated. Fixes #47

@madelson
Copy link
Owner

madelson commented Aug 7, 2020

Hi @pedropaulovc thanks for contributing.

Since adding a strong name to an assembly is a binary breaking change, I won't be able to merge this into the 1.x series.

I am currently working on the 2.0 version (see the 2.0 branch) which is intended to have strong-named assemblies. Would you consider performing this change on the 2.0 branch and filing a PR against that branch?

Thanks!

@pedropaulovc pedropaulovc changed the base branch from master to release-2.0 August 9, 2020 01:50
@pedropaulovc
Copy link
Contributor Author

@madelson Sure. I addressed your comment in the latest iteration of the PR. Let me know if you'd like any other changes. Thanks!

@madelson
Copy link
Owner

madelson commented Aug 10, 2020 via email

@pedropaulovc
Copy link
Contributor Author

I appreciate the offer but my team is pretty conservative in uptaking major version changes. We'll keep an eye for v2 release candidates. Thanks!

@madelson madelson changed the base branch from release-2.0 to strong-name August 12, 2020 11:23
@madelson
Copy link
Owner

We'll keep an eye for v2 release candidates.

Just for clarification, does this mean you'd be comfortable with something tagged as -rc, just not as -alpha?

@madelson madelson merged commit c985995 into madelson:strong-name Aug 12, 2020
@pedropaulovc pedropaulovc deleted the strongname branch August 13, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly is not strong-named
2 participants