Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

magento-engcom/import-export-improvements#58: Fix generation of import url #111

Merged
merged 1 commit into from
Jul 30, 2018
Merged

magento-engcom/import-export-improvements#58: Fix generation of import url #111

merged 1 commit into from
Jul 30, 2018

Conversation

dmanners
Copy link
Contributor

Description

  • update the building of import url in before.phtml
  • check that we do not already have the form_key in our url,
  • build the newActionUrl first so that we always are using the same url to build the url

Fixed Issues (if relevant)

  1. Incorrect Request URL with Form Key on the product import. #58: Incorrect Request URL with Form Key on the product import

Manual testing scenarios

  1. Install Magento from develop branch.
  2. Go to Admin Panel
  3. Go to System -> Import.
  4. Select "Products" in Entity Type field.
  5. Set: Import Behavior: "Add/Update", select valid file to import.
  6. Click "Check Data", wait for validation to complete.
  7. Click "Import".
  8. Check the url in the network tab of your browser,

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
magento-engcom#58: Fix generation of import url
10ce88b 
 - update the building of import url in before.phtml
 - check that we do not already have the form_key in our url,
 - build the newActionUrl first so that we always are using the same url to build the url
@VladimirZaets VladimirZaets self-assigned this Jul 24, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 24, 2018
@VladimirZaets VladimirZaets self-requested a review July 24, 2018 12:14
@magento-engcom-team magento-engcom-team merged commit 10ce88b into magento-engcom:2.3-develop Jul 30, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 30, 2018
ENGCOM-2498: #58: Fix generation of import url #111
78e16d7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels
2.3-develop Area: Frontend Component: ImportExport
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dmanners @VladimirZaets @magento-engcom-team