Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Fixed miss called property in getStoreIdByCode method #143

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Fixed miss called property in getStoreIdByCode method #143

merged 2 commits into from
Nov 14, 2018

Conversation

maxalmonte14
Copy link
Contributor

@maxalmonte14 maxalmonte14 commented Oct 26, 2018

Description (*)

This PR solves the problem addressed in #134

Fixed Issues (if relevant)

  1. Clean up Model/Import/Product/Type/Bundle.php #134: Clean up Model/Import/Product/Type/Bundle.php

Manual testing scenarios (*)

  1. Run ./vendor/bin/phpstan analyse app/code/Magento/BundleImportExport/Model/Import/Product/Type/Bundle.php as described in Clean up Model/Import/Product/Type/Bundle.php #134, after this implementation the following error shouldn't be present
------ ------------------------------------------------------------------------------------------------------------------------------------------
  Line   Bundle.php
 ------ ------------------------------------------------------------------------------------------------------------------------------------------
  782    Access to an undefined property Magento\BundleImportExport\Model\Import\Product\Type\Bundle::$storeIdToCode.
 ------ ------------------------------------------------------------------------------------------------------------------------------------------

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
Copy link
Contributor

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.

dmanners
dmanners previously approved these changes Oct 29, 2018
@magento-engcom-team
Copy link
Contributor

@maxalmonte14 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@dmanners
Copy link
Contributor

Hi @maxalmonte14 I push 1 commit to this branch (b552406) to fix some php code style issues.

@maxalmonte14
Copy link
Contributor Author

@dmanners excellent 👌

@magento-engcom-team magento-engcom-team merged commit b552406 into magento-engcom:2.3-develop Nov 14, 2018
@maxalmonte14 maxalmonte14 deleted the improvement/supress_undefined_storeIdToCode_property_error branch November 15, 2018 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants