Skip to content

August 7, 2019 #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelyu0123 opened this issue Jul 31, 2019 · 6 comments
Closed

August 7, 2019 #222

michaelyu0123 opened this issue Jul 31, 2019 · 6 comments
Labels
meeting notes Topic requests and notes from meetings

Comments

@michaelyu0123
Copy link

michaelyu0123 commented Jul 31, 2019 •
edited by buskamuza
Loading

Please add your topic as a comment to the issue. Use following format:
Topic description and link to PR, if any (duration in min)

Time: 10:00am CST/CDT

BlueJeans Meeting - https://bluejeans.com/7385677850

🎥 Recording
@michaelyu0123 michaelyu0123 added the meeting notes Topic requests and notes from meetings label Jul 31, 2019
@michaelyu0123
Copy link
Author

HLD for JS compatibility check for AMD modules marked with @api (10min)

@lenaorobei
Copy link
Contributor

lenaorobei commented Aug 5, 2019 •
edited
Loading

Coding standard rule: The use of helpers in templates magento/magento-coding-standard#122 (10 min)

@buskamuza
Copy link
Contributor

Translations in di.xml - #223 (10min)

@jednano
Copy link

jednano commented Aug 7, 2019

Apollo Federation Gateway #224

@lenaorobei
Copy link
Contributor

Coding standard rule: classes and interfaces PHPDoc formatting magento/magento-coding-standard#105 (5 min)

This was referenced Aug 7, 2019
Merged
Merged
@buskamuza
Copy link
Contributor

  • Coding standards for phpdoc blocks: do not require dock block for classes
  • Coding standards for view models vs helpers: yes, add such rule. View models can be marked as @api later.
  • Translations in di.xml - it's a bad place for translations. Investigate if it's possible to eliminate this feature at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meeting notes Topic requests and notes from meetings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jednano @buskamuza @michaelyu0123 @lenaorobei