Translations in di.xml #223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanjosiah
reviewed
Aug 1, 2019
| 1. Allow `translate` attribute in `di.xml`. | ||
| 2. `translate` attribute leads to the string being automatically translated during XML parsing and passed to the client code as translated phrase. | ||
| 2.1. If it is impossible to translate the phrase (e.g., the application is running in `global` area), the phrase is provided untranslated. | ||
| 3. Remove `translatable` attribute. Temporarily, support it as deprecated with existing behavior. |
There was a problem hiding this comment.
This would remove the ability to defer the translation. Is this an acceptable feature loss?
Closed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are
translateattribute supported in layouts, whiledi.xmlsupportstranslatablewith different behavior. This is confusing and may lead to bugs.See MAGETWO-67048 (internal issue with old discussion).
Solution
Unify translation attributes in XML files.
Requested Reviewers
@melnikovi
@maghamed
@kokoc