Skip to content

Update company.md #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2020
Merged

Update company.md #435

merged 1 commit into from
Sep 9, 2020

Conversation

nrkapoor
Copy link
Contributor

@nrkapoor nrkapoor commented Sep 9, 2020 •
edited
Loading

Problem

Schema has a lot of fields named id which doesn't align with the new naming convention.

Solution

Updating all id fields to uid to be consistent with the new naming convention.

Requested Reviewers

@melnikovi @prabhuram93

@melnikovi melnikovi self-requested a review September 9, 2020 18:12
@melnikovi melnikovi merged commit 87d8ca4 into magento:master Sep 9, 2020
@RakeshJesadiya RakeshJesadiya mentioned this pull request Oct 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melnikovi melnikovi melnikovi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrkapoor @melnikovi