Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add warning regarding GTID consistency #4129

Merged
merged 4 commits into from
Apr 9, 2019

Conversation

bradjones1
Copy link
Contributor

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will add a warning to users of MySQL regarding Magento's dependency on a TRIGGER statement that is incompatible with GTID-based replication.

Refs magento/magento2#15209

Additional information

List all affected URLs

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 1, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link

@bradjones1 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@erikmarr erikmarr self-requested a review April 8, 2019 18:21
@erikmarr erikmarr self-assigned this Apr 8, 2019
@bradjones1 bradjones1 force-pushed the mysql-compatibility branch from 3e8d8e9 to 0ab4def Compare April 8, 2019 19:57
@bradjones1
Copy link
Contributor Author

@erikmarr Thanks for the review. Changes made per request.

@erikmarr erikmarr added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Community Docs impacted by community code contribution Technical Updates to the code or processes that alter the technical content of the doc labels Apr 8, 2019
@erikmarr
Copy link
Contributor

erikmarr commented Apr 9, 2019

running tests

@erikmarr erikmarr merged commit 392a8f7 into magento:master Apr 9, 2019
@ghost
Copy link

ghost commented Apr 9, 2019

Hi @bradjones1, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@erikmarr
Copy link
Contributor

erikmarr commented Apr 9, 2019

Thanks @bradjones1!

@bradjones1
Copy link
Contributor Author

@erikmarr Thanks. Though it looks like the warning formatting isn't applying? https://devdocs.magento.com/guides/v2.2/install-gde/prereq/mysql.html

@erikmarr
Copy link
Contributor

erikmarr commented Apr 9, 2019

Thanks for letting me know! I'm looking into it now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Community Docs impacted by community code contribution Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants