This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add warning regarding GTID consistency #4129
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bradjones1 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
An admin must run tests on this PR before it can be merged. |
erikmarr
suggested changes
Apr 8, 2019
3e8d8e9
to
0ab4def
Compare
@erikmarr Thanks for the review. Changes made per request. |
keharper
reviewed
Apr 8, 2019
erikmarr
approved these changes
Apr 8, 2019
running tests |
Hi @bradjones1, thank you for your contribution! |
Thanks @bradjones1! |
@erikmarr Thanks. Though it looks like the warning formatting isn't applying? https://devdocs.magento.com/guides/v2.2/install-gde/prereq/mysql.html |
Thanks for letting me know! I'm looking into it now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will add a warning to users of MySQL regarding Magento's dependency on a
TRIGGER
statement that is incompatible with GTID-based replication.Refs magento/magento2#15209
Additional information
List all affected URLs